Update errorprone to fix java 8 issues.

Update errorprone to fix java 8 issues.

This updates errorprone from 1.1.2 to 2.0.1. Version 2.0.1 includes
some fixes that lets errorprone work if you have java 8. I also
deleted the ChromiumErrorProneCompiler to just use the default
ErrorProneCompiler instead. Currently, the ChromiumErrorProneCompiler
doesn't override any default behavior and would need to be
changed a good bit to be compatible with 2.0.1.

BUG=517259
Committed: https://crrev.com/29d8817ee93db9e2ba9177a456a4992e3ad54d99
Cr-Commit-Position: refs/heads/master@{#345688}

[mikecase (-- gone --), 2015-08-10 23:32:07]

mikecase@chromium.org changed reviewers:
+ jbudorick@chromium.org

[mikecase (-- gone --), 2015-08-10 23:32:08]

Got errorprone working with java 8. Grabbed the jar from here,
https://repo1.maven.org/maven2/com/google/errorprone/error_prone_ant/2.0.4/er...

This appears to be a different place than from where Ray got the jar currently
checked in because the naming is slightly different (his was
error_prone_core.jar where this is error_prone_ant.jar). But this jar works, and
is linked from the errorprone github under "latest release of Error Prone"
(https://github.com/google/error-prone).

Tested it in both gyp and GN and errorprone warnings and errors show up as
expected.

[mikecase (-- gone --), 2015-08-14 17:29:25]

Changed to use errorprone_core.jar.

Will need to add javacutil-1.8.10.jar and dataflow-1.8.10.jar to third_party
before I can land this CL.

[mikecase (-- gone --), 2015-08-17 20:54:09]

mikecase@chromium.org changed reviewers:
+ thakis@chromium.org

[mikecase (-- gone --), 2015-08-17 20:54:10]

+thakis for review of build/
+jbudorick for review of third_party/errorprone

[Nico, 2015-08-17 20:55:34]

https://codereview.chromium.org/1286613002/diff/60001/build/android/gyp/javac.py
File build/android/gyp/javac.py (right):

https://codereview.chromium.org/1286613002/diff/60001/build/android/gyp/javac...
build/android/gyp/javac.py:67: # warn so we can see more errors that occur later
in the build.
Builds should be silent, else people learn to tolerate and ignore warnings.

[mikecase (-- gone --), 2015-08-19 23:29:29]

https://codereview.chromium.org/1286613002/diff/60001/build/android/gyp/javac.py
File build/android/gyp/javac.py (right):

https://codereview.chromium.org/1286613002/diff/60001/build/android/gyp/javac...
build/android/gyp/javac.py:67: # warn so we can see more errors that occur later
in the build.
On 2015/08/17 at 20:55:34, Nico (on vacation Thu Aug 20) wrote:
> Builds should be silent, else people learn to tolerate and ignore warnings.

Fixed.

Have a few CLs to fix errors/warnings I got when compiling with errorprone
locally so people don't get spammed with warnings when errorprone is enabled.
Also, removed making some errorprone errors to warn instead of fail (I had
initially thought this would be run on bots only, so made some errors not fail
so errors that occurred later in the build would be visible. However, it looks
like this is just going to become the default java compiler eventually for
everyone)
https://codereview.chromium.org/1297073004
https://codereview.chromium.org/1296243003/
https://chromium-review.googlesource.com/#/c/294165

[jbudorick, 2015-08-23 02:56:08]

https://codereview.chromium.org/1286613002/diff/100001/build/config/android/i...
File build/config/android/internal_rules.gni (right):

https://codereview.chromium.org/1286613002/diff/100001/build/config/android/i...
build/config/android/internal_rules.gni:125: if (defined(invoker.testonly)) {
forward_variables_from(invoker, [ "testonly" ])

https://codereview.chromium.org/1286613002/diff/100001/build/config/android/i...
build/config/android/internal_rules.gni:145: if (defined(invoker.deps)) {
forward_variables_from(invoker, [ "deps" ])

https://codereview.chromium.org/1286613002/diff/100001/build/config/android/r...
File build/config/android/rules.gni (right):

https://codereview.chromium.org/1286613002/diff/100001/build/config/android/r...
build/config/android/rules.gni:1119: if (defined(invoker.main_class)) {
This will definitely need a rebase, and you'll probably be adding "main_class"
to a forward_variables_from call.

[mikecase (-- gone --), 2015-08-24 17:16:22]

https://codereview.chromium.org/1286613002/diff/100001/build/config/android/i...
File build/config/android/internal_rules.gni (right):

https://codereview.chromium.org/1286613002/diff/100001/build/config/android/i...
build/config/android/internal_rules.gni:125: if (defined(invoker.testonly)) {
On 2015/08/23 at 02:56:08, jbudorick wrote:
> forward_variables_from(invoker, [ "testonly" ])

Done

https://codereview.chromium.org/1286613002/diff/100001/build/config/android/i...
build/config/android/internal_rules.gni:145: if (defined(invoker.deps)) {
On 2015/08/23 at 02:56:08, jbudorick wrote:
> forward_variables_from(invoker, [ "deps" ])

Done

https://codereview.chromium.org/1286613002/diff/100001/build/config/android/r...
File build/config/android/rules.gni (right):

https://codereview.chromium.org/1286613002/diff/100001/build/config/android/r...
build/config/android/rules.gni:1119: if (defined(invoker.main_class)) {
On 2015/08/23 at 02:56:08, jbudorick wrote:
> This will definitely need a rebase, and you'll probably be adding "main_class"
to a forward_variables_from call.

It seems I can get rid of changing this file since java_prebuilt now just
forwards all of the variables.

[jbudorick, 2015-08-25 19:53:58]

lgtm w/ nit

https://codereview.chromium.org/1286613002/diff/120001/third_party/errorprone...
File third_party/errorprone/errorprone.gyp (right):

https://codereview.chromium.org/1286613002/diff/120001/third_party/errorprone...
third_party/errorprone/errorprone.gyp:64: ':error_prone_annotation_jar',
nit: while this may work, we don't typically do leading colons in gyp

[mikecase (-- gone --), 2015-08-25 21:55:04]

Tested locally and gyp and gn builds work. However, an error in mojo causes
errorprone builds to fail. Errorprone isn't enabled by default anywhere so this
CL is safe to land.

May have a follow up CL to temporarily disable errorprone on Mojo until it rolls
so I can start enabling this.

[mikecase (-- gone --), 2015-08-25 21:55:06]

The CQ bit was checked by mikecase@chromium.org

[mikecase (-- gone --), 2015-08-25 21:55:06]

The patchset sent to the CQ was uploaded after l-g-t-m from
jbudorick@chromium.org
Link to the patchset: https://codereview.chromium.org/1286613002/#ps140001
(title: "Fixed jbudorick's nits.")

[commit-bot: I haz the power, 2015-08-25 21:55:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1286613002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1286613002/140001

[commit-bot: I haz the power, 2015-08-25 22:03:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-25 22:03:50]

Try jobs failed on following builders:
  android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)

[mikecase (-- gone --), 2015-08-25 22:53:42]

The CQ bit was checked by mikecase@chromium.org

[commit-bot: I haz the power, 2015-08-25 22:53:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1286613002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1286613002/140001

[commit-bot: I haz the power, 2015-08-25 23:01:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-25 23:01:02]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)

[mikecase (-- gone --), 2015-08-26 21:25:53]

The CQ bit was checked by mikecase@chromium.org

[commit-bot: I haz the power, 2015-08-26 21:26:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1286613002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1286613002/140001

[commit-bot: I haz the power, 2015-08-26 21:47:36]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2015-08-26 21:48:19]

Patchset 8 (id:??) landed as
https://crrev.com/29d8817ee93db9e2ba9177a456a4992e3ad54d99
Cr-Commit-Position: refs/heads/master@{#345688}