Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2151)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: build/android/gyp/javac.py

Issue 1286613002: Update errorprone to fix java 8 issues. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed jbudorick's nits. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « DEPS ('k') | build/config/android/internal_rules.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/gyp/javac.py
diff --git a/build/android/gyp/javac.py b/build/android/gyp/javac.py
index dafe5dff0ab9a9f767c3105641283fa30a84cdaf..83c1b164c63ca862831afe528a6d1dc7b8ad9e0d 100755
--- a/build/android/gyp/javac.py
+++ b/build/android/gyp/javac.py
@@ -55,14 +55,10 @@ def ColorJavacOutput(output):
ERRORPRONE_OPTIONS = [
- '-Xepdisable:'
- # Something in chrome_private_java makes this check crash.
- 'com.google.errorprone.bugpatterns.ClassCanBeStatic,'
# These crash on lots of targets.
- 'com.google.errorprone.bugpatterns.WrongParameterPackage,'
- 'com.google.errorprone.bugpatterns.GuiceOverridesGuiceInjectableMethod,'
- 'com.google.errorprone.bugpatterns.GuiceOverridesJavaxInjectableMethod,'
- 'com.google.errorprone.bugpatterns.ElementsCountedInLoop'
+ '-Xep:ParameterPackage:OFF',
+ '-Xep:OverridesGuiceInjectableMethod:OFF',
+ '-Xep:OverridesJavaxInjectableMethod:OFF',
]
def DoJavac(
« no previous file with comments | « DEPS ('k') | build/config/android/internal_rules.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698