GTTF: Correctly handle perf tests

GTTF: Correctly handle perf tests

Forcing --single-process-tests is wrong: the test binary itself
should know it's a perf tests and run serially.
https://codereview.chromium.org/128593002 fixes that.

Stdout parsing logic lives buildbot-side, so the flag to force
printing test stdout is also added buildbot-side.

BUG=236893
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=244788

[Paweł Hajdan Jr., 2014-01-08 16:51:44]

This is my fix after https://codereview.chromium.org/112633009/

[ghost stip (do not use), 2014-01-08 22:06:24]

should we go ahead and hit all the affected perf steps here?

[Paweł Hajdan Jr., 2014-01-09 11:43:00]

On 2014/01/08 22:06:24, stip wrote:
> should we go ahead and hit all the affected perf steps here?

I updated ones that I can easily see https://codereview.chromium.org/128593002/
affects.

I added tonyg to also check this.

I'm fine with adding the flags to more build steps, please just tell me which
ones.

[ghost stip (do not use), 2014-01-09 19:42:00]

https://chromiumcodereview.appspot.com/128643002/diff/1/scripts/master/factor...
File scripts/master/factory/chromium_commands.py (left):

https://chromiumcodereview.appspot.com/128643002/diff/1/scripts/master/factor...
scripts/master/factory/chromium_commands.py:463:
cmd_options=['--single-process-tests'],
don't we still want single-process-tests?

[Paweł Hajdan Jr., 2014-01-10 10:05:47]

https://chromiumcodereview.appspot.com/128643002/diff/1/scripts/master/factor...
File scripts/master/factory/chromium_commands.py (left):

https://chromiumcodereview.appspot.com/128643002/diff/1/scripts/master/factor...
scripts/master/factory/chromium_commands.py:463:
cmd_options=['--single-process-tests'],
On 2014/01/09 19:42:00, stip wrote:
> don't we still want single-process-tests?

No, it's wrong. Generally it shouldn't be used buildbot-side. One notable
exception now are Valgrind tests, I just need to work with Valgrind folks on a
possibly better solution.

--single-process-tests bypasses the new test launcher, and is used internally by
the launcher, and can also be used locally to debug a specific test (as opposed
to the launcher).

I really wonder why this is taking so many round-trips. First, you've asked me
to review the original CL (https://codereview.chromium.org/112633009) and I told
you it's wrong. I added both --single-process-tests and
--test-launcher-print-test-stdio, so presumably I know what's the right way to
use them (and I'm open to feedback, but then please include rationale for using
--single-process-tests stronger than "just in case"). :) Chromium-side change
(https://codereview.chromium.org/128593002/) was unanimously approved within 5
hours.

[ghost stip (do not use), 2014-01-10 19:51:37]

lgtm

I didn't realize that the single-process change here was taken care of by the
chromium-side patch, so I wanted to be careful that we weren't breaking things.
I now realize the description stated as much and I should have caught that
earlier.

I try to limit back and forth but I'm rather unfamiliar with the test launcher
and will stay conservative until I am more familiar with it...

[commit-bot: I haz the power, 2014-01-14 19:25:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/phajdan.jr@chromium.org/128643002/1

[commit-bot: I haz the power, 2014-01-14 19:26:40]

Change committed as 244788