Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 112633009: Run media_perftests in a single process. (Closed)

Created:
6 years, 11 months ago by rileya (GONE FROM CHROMIUM)
Modified:
6 years, 11 months ago
CC:
chromium-reviews, cmp-cc_chromium.org, kjellander+cc_chromium.org, xusydoc+watch_chromium.org, ilevy-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Visibility:
Public.

Description

Run media_perftests in a single process. Running performance tests in multiple processes doesn't really make sense if we want consistent numbers, and this also fixes performance reporting to the dashboard. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=243214

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M masters/master.chromium.perf/master.cfg View 1 chunk +1 line, -1 line 0 comments Download
M scripts/master/factory/chromium_commands.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
rileya (GONE FROM CHROMIUM)
The switch to the new test runner by default seems to have broken media_perftests' perf ...
6 years, 11 months ago (2014-01-06 23:37:28 UTC) #1
ghost stip (do not use)
lgtm, this seems reasonable. Paweł and Tony, are there other perf tests where we would ...
6 years, 11 months ago (2014-01-06 23:41:36 UTC) #2
tonyg
On 2014/01/06 23:41:36, stip wrote: > lgtm, this seems reasonable. lgtm2 > Paweł and Tony, ...
6 years, 11 months ago (2014-01-06 23:44:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rileya@chromium.org/112633009/1
6 years, 11 months ago (2014-01-07 00:55:29 UTC) #4
commit-bot: I haz the power
Change committed as 243214
6 years, 11 months ago (2014-01-07 00:56:28 UTC) #5
Paweł Hajdan Jr.
6 years, 11 months ago (2014-01-08 16:52:37 UTC) #6
Message was sent while issue was closed.
Sorry, I don't think this is correct.

Please see https://codereview.chromium.org/128643002/ and
https://codereview.chromium.org/128593002 where I apply a different approach.

Powered by Google App Engine
This is Rietveld 408576698