Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 128593002: GTTF: Run perf tests serially (Closed)

Created:
6 years, 11 months ago by Paweł Hajdan Jr.
Modified:
6 years, 11 months ago
Reviewers:
jamesr, DaleCurtis, piman
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, cc-bugs_chromium.org, jam, feature-media-reviews_chromium.org
Visibility:
Public.

Description

GTTF: Run perf tests serially This makes media_perftests run serially (see https://codereview.chromium.org/112633009). Also update other perf tests (initially changed by https://codereview.chromium.org/47023009/ and https://codereview.chromium.org/52443004) now that we have LaunchUnitTestsSerially (for consistency). BUG=236893 R=dalecurtis@chromium.org, jamesr@chromium.org, piman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244806

Patch Set 1 #

Total comments: 2

Patch Set 2 : 2013 #

Patch Set 3 : 2014 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -5 lines) Patch
M cc/test/run_all_perftests.cc View 2 chunks +7 lines, -1 line 0 comments Download
M content/test/run_all_perftests.cc View 2 chunks +5 lines, -1 line 0 comments Download
A + media/base/run_all_perftests.cc View 1 2 chunks +5 lines, -2 lines 0 comments Download
M media/media.gyp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Paweł Hajdan Jr.
Please review: jamesr: cc/ piman: content/ dalecurtis: media/
6 years, 11 months ago (2014-01-08 16:55:56 UTC) #1
jamesr
cc/ lgtm https://codereview.chromium.org/128593002/diff/1/media/base/run_all_perftests.cc File media/base/run_all_perftests.cc (right): https://codereview.chromium.org/128593002/diff/1/media/base/run_all_perftests.cc#newcode1 media/base/run_all_perftests.cc:1: // Copyright 2013 The Chromium Authors. All ...
6 years, 11 months ago (2014-01-08 18:42:20 UTC) #2
piman
lgtm
6 years, 11 months ago (2014-01-08 21:54:14 UTC) #3
DaleCurtis
lgtm
6 years, 11 months ago (2014-01-08 21:58:20 UTC) #4
Paweł Hajdan Jr.
https://codereview.chromium.org/128593002/diff/1/media/base/run_all_perftests.cc File media/base/run_all_perftests.cc (right): https://codereview.chromium.org/128593002/diff/1/media/base/run_all_perftests.cc#newcode1 media/base/run_all_perftests.cc:1: // Copyright 2013 The Chromium Authors. All rights reserved. ...
6 years, 11 months ago (2014-01-14 21:37:52 UTC) #5
Paweł Hajdan Jr.
6 years, 11 months ago (2014-01-14 21:40:57 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 manually as r244806 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698