Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1286383003: Mandoline: Enable Android software keyboard for the Omnibox. (Closed)

Created:
5 years, 4 months ago by Peng
Modified:
5 years, 4 months ago
Reviewers:
sky
CC:
chromium-reviews, sadrul, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, penghuang+watch-mandoline_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, kalyank, piman+watch_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mandoline: Enable Android software keyboard for the Omnibox. BUG=498624 Committed: https://crrev.com/d1e9dbab0625b85ef3db72b1a100fb7d9db5cb3c Cr-Commit-Position: refs/heads/master@{#343679}

Patch Set 1 : Update #

Total comments: 4

Patch Set 2 : address review issues #

Unified diffs Side-by-side diffs Delta from patch set Stats (+187 lines, -180 lines) Patch
M components/html_viewer/blink_text_input_type_converters.cc View 1 chunk +10 lines, -10 lines 0 comments Download
M components/view_manager/BUILD.gn View 2 chunks +1 line, -2 lines 0 comments Download
D components/view_manager/type_converters.h View 1 chunk +0 lines, -25 lines 0 comments Download
M components/view_manager/type_converters.cc View 1 chunk +0 lines, -70 lines 0 comments Download
M components/view_manager/view_manager_service_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M mandoline/ui/aura/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M mandoline/ui/aura/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M mandoline/ui/aura/input_method_mandoline.h View 1 1 chunk +18 lines, -1 line 0 comments Download
M mandoline/ui/aura/input_method_mandoline.cc View 1 5 chunks +40 lines, -1 line 0 comments Download
M mandoline/ui/aura/window_tree_host_mojo.cc View 1 chunk +1 line, -1 line 0 comments Download
M mandoline/ui/omnibox/omnibox_impl.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
A + mojo/converters/ime/BUILD.gn View 1 chunk +11 lines, -9 lines 0 comments Download
A mojo/converters/ime/DEPS View 1 chunk +6 lines, -0 lines 0 comments Download
A mojo/converters/ime/ime_type_converters.h View 1 chunk +31 lines, -0 lines 0 comments Download
A + mojo/converters/ime/ime_type_converters.cc View 2 chunks +17 lines, -13 lines 0 comments Download
A mojo/converters/ime/mojo_ime_export.h View 1 chunk +32 lines, -0 lines 0 comments Download
M ui/mojo/ime/text_input_state.mojom View 2 chunks +11 lines, -11 lines 0 comments Download
M ui/platform_window/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M ui/platform_window/text_input_state.h View 1 chunk +3 lines, -36 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Peng
Hi Scott, PTAL. Thanks.
5 years, 4 months ago (2015-08-14 18:02:46 UTC) #5
sky
LGTM https://codereview.chromium.org/1286383003/diff/60001/mandoline/ui/aura/input_method_mandoline.cc File mandoline/ui/aura/input_method_mandoline.cc (right): https://codereview.chromium.org/1286383003/diff/60001/mandoline/ui/aura/input_method_mandoline.cc#newcode96 mandoline/ui/aura/input_method_mandoline.cc:96: void InputMethodMandoline::OnWillChangeFocusedClient( nit: remove this as it's the ...
5 years, 4 months ago (2015-08-14 19:59:23 UTC) #6
Peng
https://codereview.chromium.org/1286383003/diff/60001/mandoline/ui/aura/input_method_mandoline.cc File mandoline/ui/aura/input_method_mandoline.cc (right): https://codereview.chromium.org/1286383003/diff/60001/mandoline/ui/aura/input_method_mandoline.cc#newcode96 mandoline/ui/aura/input_method_mandoline.cc:96: void InputMethodMandoline::OnWillChangeFocusedClient( On 2015/08/14 19:59:23, sky wrote: > nit: ...
5 years, 4 months ago (2015-08-17 13:26:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1286383003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1286383003/80001
5 years, 4 months ago (2015-08-17 13:57:27 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:80001)
5 years, 4 months ago (2015-08-17 14:36:17 UTC) #11
commit-bot: I haz the power
5 years, 4 months ago (2015-08-17 14:36:47 UTC) #12
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/d1e9dbab0625b85ef3db72b1a100fb7d9db5cb3c
Cr-Commit-Position: refs/heads/master@{#343679}

Powered by Google App Engine
This is Rietveld 408576698