Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Unified Diff: mandoline/ui/aura/input_method_mandoline.cc

Issue 1286383003: Mandoline: Enable Android software keyboard for the Omnibox. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address review issues Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mandoline/ui/aura/input_method_mandoline.h ('k') | mandoline/ui/aura/window_tree_host_mojo.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mandoline/ui/aura/input_method_mandoline.cc
diff --git a/mandoline/ui/aura/input_method_mandoline.cc b/mandoline/ui/aura/input_method_mandoline.cc
index 5857466112d1f512612d6e9f6673fde83a6f42e8..521240e4fead82e5fd6c8beb9c14bbea5f106b5e 100644
--- a/mandoline/ui/aura/input_method_mandoline.cc
+++ b/mandoline/ui/aura/input_method_mandoline.cc
@@ -4,8 +4,11 @@
#include "mandoline/ui/aura/input_method_mandoline.h"
+#include "components/view_manager/public/cpp/view.h"
+#include "mojo/converters/ime/ime_type_converters.h"
#include "ui/base/ime/text_input_client.h"
#include "ui/events/event.h"
+#include "ui/mojo/ime/text_input_state.mojom.h"
namespace mandoline {
@@ -13,7 +16,9 @@ namespace mandoline {
// InputMethodMandoline, public:
InputMethodMandoline::InputMethodMandoline(
- ui::internal::InputMethodDelegate* delegate) {
+ ui::internal::InputMethodDelegate* delegate,
+ mojo::View* view)
+ : view_(view) {
SetDelegate(delegate);
}
@@ -22,6 +27,16 @@ InputMethodMandoline::~InputMethodMandoline() {}
////////////////////////////////////////////////////////////////////////////////
// InputMethodMandoline, ui::InputMethod implementation:
+void InputMethodMandoline::OnFocus() {
+ InputMethodBase::OnFocus();
+ UpdateTextInputType();
+}
+
+void InputMethodMandoline::OnBlur() {
+ InputMethodBase::OnBlur();
+ UpdateTextInputType();
+}
+
bool InputMethodMandoline::OnUntranslatedIMEMessage(
const base::NativeEvent& event,
NativeEventResult* result) {
@@ -51,6 +66,13 @@ void InputMethodMandoline::DispatchKeyEvent(ui::KeyEvent* event) {
ignore_result(DispatchKeyEventPostIME(event));
}
+void InputMethodMandoline::OnTextInputTypeChanged(
+ const ui::TextInputClient* client) {
+ if (IsTextInputClientFocused(client))
+ UpdateTextInputType();
+ InputMethodBase::OnTextInputTypeChanged(client);
+}
+
void InputMethodMandoline::OnCaretBoundsChanged(
const ui::TextInputClient* client) {
}
@@ -70,4 +92,21 @@ bool InputMethodMandoline::IsCandidatePopupOpen() const {
return false;
}
+void InputMethodMandoline::OnDidChangeFocusedClient(
+ ui::TextInputClient* focused_before,
+ ui::TextInputClient* focused) {
+ InputMethodBase::OnDidChangeFocusedClient(focused_before, focused);
+ UpdateTextInputType();
+}
+
+void InputMethodMandoline::UpdateTextInputType() {
+ ui::TextInputType type = GetTextInputType();
+ mojo::TextInputStatePtr state = mojo::TextInputState::New();
+ state->type = mojo::ConvertTo<mojo::TextInputType>(type);
+ if (type != ui::TEXT_INPUT_TYPE_NONE)
+ view_->SetImeVisibility(true, state.Pass());
+ else
+ view_->SetTextInputState(state.Pass());
+}
+
} // namespace mandoline
« no previous file with comments | « mandoline/ui/aura/input_method_mandoline.h ('k') | mandoline/ui/aura/window_tree_host_mojo.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698