components/view_manager/view_manager_service_impl.cc - Issue 1286383003: Mandoline: Enable Android software keyboard for the Omnibox.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/view_manager/view_manager_service_impl.cc

Issue 1286383003: Mandoline: Enable Android software keyboard for the Omnibox. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address review issues Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/view_manager/view_manager_service_impl.cc

diff --git a/components/view_manager/view_manager_service_impl.cc b/components/view_manager/view_manager_service_impl.cc

index bbe1779344281a42e27bcda39fe9d77475ec86a5..c8dc8509dd6c9394cb28d04eddf5b6b428968fae 100644

--- a/components/view_manager/view_manager_service_impl.cc

+++ b/components/view_manager/view_manager_service_impl.cc

@@ -10,9 +10,9 @@

#include "components/view_manager/default_access_policy.h"

#include "components/view_manager/display_manager.h"

#include "components/view_manager/server_view.h"

-#include "components/view_manager/type_converters.h"

#include "components/view_manager/window_manager_access_policy.h"

#include "mojo/converters/geometry/geometry_type_converters.h"

+#include "mojo/converters/ime/ime_type_converters.h"

#include "mojo/converters/input_events/input_events_type_converters.h"

#include "mojo/converters/surfaces/surfaces_type_converters.h"

#include "ui/platform_window/text_input_state.h"

« no previous file with comments | « components/view_manager/type_converters.cc ('k') | mandoline/ui/aura/BUILD.gn » ('j') | no next file with comments »