HTTPTransport test: Deal with limited-size pipe buffers

HTTPTransport test: Deal with limited-size pipe buffers

HTTPTransport.Upload33k failed on Windows due to WinHTTP timing out. The
test server, http_transport_test_server.py, writes the entire request to
a stdout pipe, to be received by crashpad_util_test. crashpad_util_test
is also the HTTP client, and it does not attempt to read from this pipe
until the HTTP transaction is complete. http_transport_test_server.py
must not write to stdout until the transaction is complete, otherwise,
there is a risk of deadlock if the pipe buffer fills up. The new
Upload33k test sends a large request, which was filling up the pipe
buffer on Windows.

This also adds an Upload33k_LengthUnknown test variant to exercise a
large POST when the length is not known ahead of time. This more closely
matches how Crashpad crash uploads are done on OS X.

TEST=crashpad_util_test HTTPTransport.*
R=rsesek@chromium.org

Committed: https://chromium.googlesource.com/crashpad/crashpad/+/14a22412747a79d9511bdf7505ae8b5f1ba3a2c7

[Mark Mentovai, 2015-08-18 21:25:26]

mark@chromium.org changed reviewers:
+ rsesek@chromium.org, scottmg@chromium.org

[Mark Mentovai, 2015-08-18 21:26:20]

https://codereview.chromium.org/1286173007/diff/1/util/net/http_transport_tes...
File util/net/http_transport_test_server.py (right):

https://codereview.chromium.org/1286173007/diff/1/util/net/http_transport_tes...
util/net/http_transport_test_server.py:67: to_write_to_stdout = ''
I don’t like that this is a global, but BaseHTTPServer has this silly interface
where you give it a class instead of an object, so I don’t think there’s really
a better place to put this. Suggestions welcome.

[Robert Sesek, 2015-08-18 21:42:50]

LGTM

https://codereview.chromium.org/1286173007/diff/1/util/net/http_transport_tes...
File util/net/http_transport_test_server.py (right):

https://codereview.chromium.org/1286173007/diff/1/util/net/http_transport_tes...
util/net/http_transport_test_server.py:67: to_write_to_stdout = ''
On 2015/08/18 21:26:19, Mark Mentovai - out til August wrote:
> I don’t like that this is a global, but BaseHTTPServer has this silly
interface
> where you give it a class instead of an object, so I don’t think there’s
really
> a better place to put this. Suggestions welcome.

You could move it to RequestHandler.written_response_body, but it'll still be
global state.

[Mark Mentovai, 2015-08-18 21:51:49]

Robert Sesek wrote:
> You could move it to RequestHandler.written_response_body, but it'll still be
> global state.

Yeah, the chief awfulness of the global is still there, but it’s slightly less
awful because it’s not so nakedly exposed. I named it raw_request.

[Mark Mentovai, 2015-08-18 21:52:17]

Committed patchset #2 (id:20001) manually as
14a22412747a79d9511bdf7505ae8b5f1ba3a2c7 (presubmit successful).