Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Unified Diff: util/net/http_transport_test.cc

Issue 1286173007: HTTPTransport test: Deal with limited-size pipe buffers (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Use a class variable, RequestHandler.raw_request Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | util/net/http_transport_test_server.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: util/net/http_transport_test.cc
diff --git a/util/net/http_transport_test.cc b/util/net/http_transport_test.cc
index 25a1a43a3264bf2f84888828208fedff87e4a3e3..0bb2985738a21e69901c633dd5ea1a56bb1c790f 100644
--- a/util/net/http_transport_test.cc
+++ b/util/net/http_transport_test.cc
@@ -278,7 +278,7 @@ TEST(HTTPTransport, UnchunkedPlainText) {
test.Run();
}
-TEST(HTTPTransport, Upload33k) {
+void RunUpload33k(bool has_content_length) {
// On OS X, NSMutableURLRequest winds up calling into a CFReadStream’s Read()
// callback with a 32kB buffer. Make sure that it’s able to get everything
// when enough is available to fill this buffer, requiring more than one
@@ -290,8 +290,10 @@ TEST(HTTPTransport, Upload33k) {
HTTPHeaders headers;
headers[kContentType] = "application/octet-stream";
- headers[kContentLength] =
- base::StringPrintf("%" PRIuS, request_string.size());
+ if (has_content_length) {
+ headers[kContentLength] =
+ base::StringPrintf("%" PRIuS, request_string.size());
+ }
HTTPTransportTestFixture test(headers, body_stream.Pass(), 200,
[](HTTPTransportTestFixture* fixture, const std::string& request) {
size_t body_start = request.rfind("\r\n");
@@ -300,6 +302,15 @@ TEST(HTTPTransport, Upload33k) {
test.Run();
}
+TEST(HTTPTransport, Upload33k) {
+ RunUpload33k(true);
+}
+
+TEST(HTTPTransport, Upload33k_LengthUnknown) {
+ // The same as Upload33k, but without declaring Content-Length ahead of time.
+ RunUpload33k(false);
+}
+
} // namespace
} // namespace test
} // namespace crashpad
« no previous file with comments | « no previous file | util/net/http_transport_test_server.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698