Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Side by Side Diff: util/net/http_transport_test.cc

Issue 1286173007: HTTPTransport test: Deal with limited-size pipe buffers (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Use a class variable, RequestHandler.raw_request Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | util/net/http_transport_test_server.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Crashpad Authors. All rights reserved. 1 // Copyright 2014 The Crashpad Authors. All rights reserved.
2 // 2 //
3 // Licensed under the Apache License, Version 2.0 (the "License"); 3 // Licensed under the Apache License, Version 2.0 (the "License");
4 // you may not use this file except in compliance with the License. 4 // you may not use this file except in compliance with the License.
5 // You may obtain a copy of the License at 5 // You may obtain a copy of the License at
6 // 6 //
7 // http://www.apache.org/licenses/LICENSE-2.0 7 // http://www.apache.org/licenses/LICENSE-2.0
8 // 8 //
9 // Unless required by applicable law or agreed to in writing, software 9 // Unless required by applicable law or agreed to in writing, software
10 // distributed under the License is distributed on an "AS IS" BASIS, 10 // distributed under the License is distributed on an "AS IS" BASIS,
(...skipping 260 matching lines...) Expand 10 before | Expand all | Expand 10 after
271 271
272 HTTPHeaders headers; 272 HTTPHeaders headers;
273 headers[kContentType] = kTextPlain; 273 headers[kContentType] = kTextPlain;
274 headers[kContentLength] = base::StringPrintf("%" PRIuS, strlen(kTextBody)); 274 headers[kContentLength] = base::StringPrintf("%" PRIuS, strlen(kTextBody));
275 275
276 HTTPTransportTestFixture test(headers, body_stream.Pass(), 200, 276 HTTPTransportTestFixture test(headers, body_stream.Pass(), 200,
277 &UnchunkedPlainText); 277 &UnchunkedPlainText);
278 test.Run(); 278 test.Run();
279 } 279 }
280 280
281 TEST(HTTPTransport, Upload33k) { 281 void RunUpload33k(bool has_content_length) {
282 // On OS X, NSMutableURLRequest winds up calling into a CFReadStream’s Read() 282 // On OS X, NSMutableURLRequest winds up calling into a CFReadStream’s Read()
283 // callback with a 32kB buffer. Make sure that it’s able to get everything 283 // callback with a 32kB buffer. Make sure that it’s able to get everything
284 // when enough is available to fill this buffer, requiring more than one 284 // when enough is available to fill this buffer, requiring more than one
285 // Read(). 285 // Read().
286 286
287 std::string request_string(33 * 1024, 'a'); 287 std::string request_string(33 * 1024, 'a');
288 scoped_ptr<HTTPBodyStream> body_stream( 288 scoped_ptr<HTTPBodyStream> body_stream(
289 new StringHTTPBodyStream(request_string)); 289 new StringHTTPBodyStream(request_string));
290 290
291 HTTPHeaders headers; 291 HTTPHeaders headers;
292 headers[kContentType] = "application/octet-stream"; 292 headers[kContentType] = "application/octet-stream";
293 headers[kContentLength] = 293 if (has_content_length) {
294 base::StringPrintf("%" PRIuS, request_string.size()); 294 headers[kContentLength] =
295 base::StringPrintf("%" PRIuS, request_string.size());
296 }
295 HTTPTransportTestFixture test(headers, body_stream.Pass(), 200, 297 HTTPTransportTestFixture test(headers, body_stream.Pass(), 200,
296 [](HTTPTransportTestFixture* fixture, const std::string& request) { 298 [](HTTPTransportTestFixture* fixture, const std::string& request) {
297 size_t body_start = request.rfind("\r\n"); 299 size_t body_start = request.rfind("\r\n");
298 EXPECT_EQ(33 * 1024u + 2, request.size() - body_start); 300 EXPECT_EQ(33 * 1024u + 2, request.size() - body_start);
299 }); 301 });
300 test.Run(); 302 test.Run();
301 } 303 }
302 304
305 TEST(HTTPTransport, Upload33k) {
306 RunUpload33k(true);
307 }
308
309 TEST(HTTPTransport, Upload33k_LengthUnknown) {
310 // The same as Upload33k, but without declaring Content-Length ahead of time.
311 RunUpload33k(false);
312 }
313
303 } // namespace 314 } // namespace
304 } // namespace test 315 } // namespace test
305 } // namespace crashpad 316 } // namespace crashpad
OLDNEW
« no previous file with comments | « no previous file | util/net/http_transport_test_server.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698