Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 1285473002: Revert of Return Windows error code when create-process fails. (Closed)

Created:
5 years, 4 months ago by bcwhite
Modified:
5 years, 4 months ago
CC:
chromium-reviews, grt+watch_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Return Windows error code when create-process fails. (patchset #14 id:260001 of https://codereview.chromium.org/1247993002/ ) Reason for revert: Looks like some other file needs to be added to the .gn as well. <sigh> Original issue's description: > Return Windows error code when create-process fails. > > COULD_NOT_CREATE_PROCESS makes up about 10% of the setup errors; include the actual DWORD result code returned by ::CreateProcess by placing all result information into the proper location of the Registry for reading by Omaha. > > BUG= > > Committed: https://crrev.com/135f5f669574bd07eaedaf6b57503984aeb13be8 > Cr-Commit-Position: refs/heads/master@{#341938} > > Committed: https://crrev.com/41465440adac9c4ca529d42bc685eedb640c8eb7 > Cr-Commit-Position: refs/heads/master@{#342528} TBR=grt@chromium.org,ganesh@chromium.org,robertshield@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/7a8f0640ac49e7a0eaa79605e7b57d8fd772d344 Cr-Commit-Position: refs/heads/master@{#342530}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+218 lines, -425 lines) Patch
M chrome/chrome_installer.gypi View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/installer/mini_installer.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/installer/mini_installer.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/installer/mini_installer/configuration.h View 2 chunks +0 lines, -12 lines 0 comments Download
M chrome/installer/mini_installer/configuration.cc View 3 chunks +1 line, -57 lines 0 comments Download
M chrome/installer/mini_installer/configuration_test.cc View 2 chunks +3 lines, -40 lines 0 comments Download
M chrome/installer/mini_installer/mini_installer.cc View 23 chunks +214 lines, -136 lines 0 comments Download
M chrome/installer/mini_installer/mini_installer_constants.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/installer/mini_installer/mini_installer_constants.cc View 1 chunk +0 lines, -4 lines 0 comments Download
D chrome/installer/mini_installer/regkey.h View 1 chunk +0 lines, -65 lines 0 comments Download
D chrome/installer/mini_installer/regkey.cc View 1 chunk +0 lines, -98 lines 0 comments Download
M chrome/installer/setup/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
bcwhite
Created Revert of Return Windows error code when create-process fails.
5 years, 4 months ago (2015-08-08 16:12:23 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1285473002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1285473002/1
5 years, 4 months ago (2015-08-08 16:12:28 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-08 16:12:51 UTC) #3
commit-bot: I haz the power
5 years, 4 months ago (2015-08-08 16:13:38 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7a8f0640ac49e7a0eaa79605e7b57d8fd772d344
Cr-Commit-Position: refs/heads/master@{#342530}

Powered by Google App Engine
This is Rietveld 408576698