Revert of Return Windows error code when create-process fails.

chrome/installer/mini_installer/configuration_test.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/installer/mini_installer/configuration.h"
 
 #include <stdlib.h>
 
 #include "base/basictypes.h"
 #include "chrome/installer/mini_installer/appid.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 using mini_installer::Configuration;
 
 class TestConfiguration : public Configuration {
  public:
   explicit TestConfiguration(const wchar_t* command_line) : Configuration() {
     Initialize(command_line);
   }
-  explicit TestConfiguration(const wchar_t* command_line,
-                             LONG ret, const wchar_t* value)
-      : Configuration(),
-        open_registry_key_result_(true),
-        read_registry_value_result_(ret),
-        read_registry_value_(value) {
-    Initialize(command_line);
-  }
-  void SetRegistryResults(bool openkey, LONG ret, const wchar_t* value) {
-  }
  private:
-  bool open_registry_key_result_;
-  LONG read_registry_value_result_;
-  const wchar_t* read_registry_value_ = L"";
-
   void Initialize(const wchar_t* command_line) {
     Clear();
     ASSERT_TRUE(ParseCommandLine(command_line));
   }
-  bool ReadClientStateRegistryValue(
-      const HKEY root_key, const wchar_t* app_guid,
-      LONG* retval, ValueString& value) override {
-    *retval = read_registry_value_result_;
-    value.assign(read_registry_value_);
-    return open_registry_key_result_;
-  }
 };
 
 // Test that the operation type is CLEANUP iff --cleanup is on the cmdline.
 TEST(MiniInstallerConfigurationTest, Operation) {
   EXPECT_EQ(Configuration::INSTALL_PRODUCT,
             TestConfiguration(L"spam.exe").operation());
   EXPECT_EQ(Configuration::INSTALL_PRODUCT,
             TestConfiguration(L"spam.exe --clean").operation());
   EXPECT_EQ(Configuration::INSTALL_PRODUCT,
             TestConfiguration(L"spam.exe --cleanupthis").operation());
@@ skipping 31 matching lines @@
                 TestConfiguration(kCommandLines[i]).command_line());
   }
 }
 
 TEST(MiniInstallerConfigurationTest, ChromeAppGuid) {
   EXPECT_TRUE(std::wstring(google_update::kAppGuid) ==
               TestConfiguration(L"spam.exe").chrome_app_guid());
   EXPECT_TRUE(std::wstring(google_update::kAppGuid) ==
               TestConfiguration(L"spam.exe --chrome").chrome_app_guid());
   EXPECT_TRUE(std::wstring(google_update::kAppGuid) ==
+              TestConfiguration(L"spam.exe --multi-install --chrome")
+                  .chrome_app_guid());
+  EXPECT_TRUE(std::wstring(google_update::kAppGuid) ==
               TestConfiguration(L"spam.exe --chrome-frame").chrome_app_guid());
   EXPECT_TRUE(std::wstring(google_update::kSxSAppGuid) ==
               TestConfiguration(L"spam.exe --chrome-sxs").chrome_app_guid());
-  EXPECT_TRUE(std::wstring(google_update::kMultiInstallAppGuid) ==
-              TestConfiguration(L"spam.exe --multi-install --chrome")
-                  .chrome_app_guid());
-  EXPECT_TRUE(std::wstring(google_update::kMultiInstallAppGuid) ==
-              TestConfiguration(L"spam.exe --multi-install --chrome",
-                                ERROR_INVALID_FUNCTION, L"")
-                  .chrome_app_guid());
-  EXPECT_TRUE(std::wstring(google_update::kAppGuid) ==
-              TestConfiguration(L"spam.exe --multi-install --chrome",
-                                ERROR_FILE_NOT_FOUND, L"")
-                  .chrome_app_guid());
-  EXPECT_TRUE(std::wstring(google_update::kAppGuid) ==
-              TestConfiguration(L"spam.exe --multi-install --chrome",
-                                ERROR_SUCCESS, L"foo-bar")
-                  .chrome_app_guid());
-  EXPECT_TRUE(std::wstring(google_update::kMultiInstallAppGuid) ==
-              TestConfiguration(L"spam.exe --multi-install --chrome",
-                                ERROR_SUCCESS, L"foo-multi")
-                  .chrome_app_guid());
 }
 
 TEST(MiniInstallerConfigurationTest, HasChrome) {
   EXPECT_TRUE(TestConfiguration(L"spam.exe").has_chrome());
   EXPECT_TRUE(TestConfiguration(L"spam.exe --chrome").has_chrome());
   EXPECT_TRUE(TestConfiguration(L"spam.exe --multi-install --chrome")
                   .has_chrome());
   EXPECT_FALSE(TestConfiguration(L"spam.exe --chrome-frame").has_chrome());
   EXPECT_FALSE(TestConfiguration(L"spam.exe --multi-install").has_chrome());
 }
@@ skipping 21 matching lines @@
                   .is_multi_install());
   EXPECT_TRUE(TestConfiguration(L"spam.exe --multi-install")
                   .is_multi_install());
 }
 
 TEST(MiniInstallerConfigurationTest, IsSystemLevel) {
   EXPECT_FALSE(TestConfiguration(L"spam.exe").is_system_level());
   EXPECT_FALSE(TestConfiguration(L"spam.exe --chrome").is_system_level());
   EXPECT_TRUE(TestConfiguration(L"spam.exe --system-level").is_system_level());
 }