Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(598)

Unified Diff: chrome/browser/webdata/web_data_service_base.cc

Issue 12853004: Move creation of WebDatabaseTable subclasses to WebDatabaseServiceFactory. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merge to parent and head. Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/webdata/web_data_service_base.cc
diff --git a/chrome/browser/webdata/web_data_service_base.cc b/chrome/browser/webdata/web_data_service_base.cc
index 49d791d0e6275722196ee59102e5e0a00e94d668..f9f8f407ba4b681768e9dc1c8fd18ef0844d574b 100644
--- a/chrome/browser/webdata/web_data_service_base.cc
+++ b/chrome/browser/webdata/web_data_service_base.cc
@@ -46,8 +46,14 @@ void WebDataServiceBase::ShutdownOnUIThread() {
ShutdownDatabase();
}
+void WebDataServiceBase::AddTable(scoped_ptr<WebDatabaseTable> table) {
+ if (!wdbs_.get())
+ wdbs_.reset(new WebDatabaseService(path));
Cait (Slow) 2013/03/21 00:01:56 I think we can just add a temporary |path_| member
+ wdbs_->AddTable(table.Pass());
+}
+
void WebDataServiceBase::Init(const base::FilePath& path) {
- wdbs_.reset(new WebDatabaseService(path));
+ DCHECK(wdbs_.get());
wdbs_->LoadDatabase(Bind(&WebDataServiceBase::DatabaseInitOnDB, this));
}
« no previous file with comments | « chrome/browser/api/webdata/web_data_service_base.h ('k') | chrome/browser/webdata/web_data_service_factory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698