Move creation of WebDatabaseTable subclasses to WebDatabaseServiceFactory.

chrome/browser/webdata/web_data_service_base.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/api/webdata/web_data_service_base.h"
 
 #include "base/bind.h"
 #include "base/message_loop.h"
 #include "base/stl_util.h"
 #include "base/threading/thread.h"
@@ skipping 28 matching lines @@
 }
 
 void WebDataServiceBase::ShutdownOnUIThread() {
   db_loaded_ = false;
   BrowserThread::PostTask(
       BrowserThread::DB, FROM_HERE,
       base::Bind(&WebDataServiceBase::ShutdownOnDBThread, this));
   ShutdownDatabase();
 }
 
+void WebDataServiceBase::AddTable(scoped_ptr<WebDatabaseTable> table) {
+  if (!wdbs_.get())
+    wdbs_.reset(new WebDatabaseService(path));

[Cait (Slow), 2013/03/21 00:01:56]

I think we can just add a temporary |path_| member to WDSBase to store the db
path and either pass it in in the ctor or set it after. both can go away after
my change lands as the DB will be created and init'ed in the factory. 

+  wdbs_->AddTable(table.Pass());
+}
+
 void WebDataServiceBase::Init(const base::FilePath& path) {
-  wdbs_.reset(new WebDatabaseService(path));
+  DCHECK(wdbs_.get());
   wdbs_->LoadDatabase(Bind(&WebDataServiceBase::DatabaseInitOnDB, this));
 }
 
 void WebDataServiceBase::UnloadDatabase() {
   if (!wdbs_)
     return;
   wdbs_->UnloadDatabase();
 }
 
 void WebDataServiceBase::ShutdownDatabase() {
@@ skipping 64 matching lines @@
     BrowserThread::PostTask(
         BrowserThread::UI, FROM_HERE,
         base::Bind(&WebDataServiceBase::NotifyDatabaseLoadedOnUIThread, this));
   } else {
     BrowserThread::PostTask(
         BrowserThread::UI, FROM_HERE,
         base::Bind(&WebDataServiceBase::DBInitFailed, this, status));
   }
 }