Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Unified Diff: chrome/browser/api/webdata/web_data_service_base.h

Issue 12853004: Move creation of WebDatabaseTable subclasses to WebDatabaseServiceFactory. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merge to parent and head. Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/api/webdata/web_data_service_base.h
diff --git a/chrome/browser/api/webdata/web_data_service_base.h b/chrome/browser/api/webdata/web_data_service_base.h
index 1c92550067234f8b2f2b59a31321e70c12e794da..974dcd0b47747f34e5ac775e426eb2eb86066ee8 100644
--- a/chrome/browser/api/webdata/web_data_service_base.h
+++ b/chrome/browser/api/webdata/web_data_service_base.h
@@ -16,6 +16,7 @@
class WebDatabase;
class WebDatabaseService;
+class WebDatabaseTable;
namespace base {
class Thread;
@@ -52,6 +53,15 @@ class WebDataServiceBase
// call.
virtual void ShutdownOnUIThread();
+ // Adds the given table to the database. Passes ownership. Must be
+ // called for all tables before Init.
+ //
+ // TODO(joi): This method is duplicated a couple of layers deep;
+ // once we have a single object creating the WebDatabaseService as
+ // well as all the XyzWebDataService objects, we should be able to
+ // simplify.
+ void AddTable(scoped_ptr<WebDatabaseTable> table);
+
// Initializes the web data service.
virtual void Init(const base::FilePath& path);
« no previous file with comments | « no previous file | chrome/browser/webdata/web_data_service_base.cc » ('j') | chrome/browser/webdata/web_data_service_base.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698