Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 1285223002: Add metrics for tracking LoginDatabase::Init failure. (Closed)

Created:
5 years, 4 months ago by vasilii
Modified:
5 years, 4 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, gcasto+watchlist_chromium.org, vabr+watchlist_chromium.org, asvitkine+watch_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add metrics for tracking LoginDatabase::Init failure. BUG=419070 Committed: https://crrev.com/8e0cdc35bc840eb9c1ccc058725ee6448f0972d8 Cr-Commit-Position: refs/heads/master@{#343353}

Patch Set 1 #

Total comments: 8

Patch Set 2 : comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -0 lines) Patch
M components/password_manager/core/browser/login_database.cc View 1 8 chunks +32 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 chunks +25 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
vasilii
Hi Ilya, please review.
5 years, 4 months ago (2015-08-12 17:26:13 UTC) #2
Ilya Sherman
https://codereview.chromium.org/1285223002/diff/1/components/password_manager/core/browser/login_database.cc File components/password_manager/core/browser/login_database.cc (right): https://codereview.chromium.org/1285223002/diff/1/components/password_manager/core/browser/login_database.cc#newcode87 components/password_manager/core/browser/login_database.cc:87: enum DatabaseInitError { Please document that this is used ...
5 years, 4 months ago (2015-08-13 00:34:18 UTC) #3
vasilii
https://codereview.chromium.org/1285223002/diff/1/components/password_manager/core/browser/login_database.cc File components/password_manager/core/browser/login_database.cc (right): https://codereview.chromium.org/1285223002/diff/1/components/password_manager/core/browser/login_database.cc#newcode87 components/password_manager/core/browser/login_database.cc:87: enum DatabaseInitError { On 2015/08/13 00:34:18, Ilya Sherman wrote: ...
5 years, 4 months ago (2015-08-13 09:04:33 UTC) #4
Ilya Sherman
LGTM, thanks.
5 years, 4 months ago (2015-08-13 21:53:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1285223002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1285223002/20001
5 years, 4 months ago (2015-08-14 08:23:01 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-14 08:27:05 UTC) #8
commit-bot: I haz the power
5 years, 4 months ago (2015-08-14 08:27:54 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8e0cdc35bc840eb9c1ccc058725ee6448f0972d8
Cr-Commit-Position: refs/heads/master@{#343353}

Powered by Google App Engine
This is Rietveld 408576698