Add metrics for tracking LoginDatabase::Init failure.

components/password_manager/core/browser/login_database.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/password_manager/core/browser/login_database.h"
 
 #include <algorithm>
 #include <limits>
 
 #include "base/bind.h"
@@ skipping 66 matching lines @@
   COLUMN_DATE_SYNCED,
   COLUMN_DISPLAY_NAME,
   COLUMN_AVATAR_URL,
   COLUMN_FEDERATION_URL,
   COLUMN_SKIP_ZERO_CLICK,
   COLUMN_GENERATION_UPLOAD_STATUS,
 };
 
 enum class HistogramSize { SMALL, LARGE };
 
+enum DatabaseInitError {

[Ilya Sherman, 2015/08/13 00:34:18]

Please document that this is used to back an UMA histogram, and therefore should
be treated as append-only.

[vasilii, 2015/08/13 09:04:33]

Done.

+  OPEN_FILE_ERROR,
+  START_TRANSACTION_ERROR,
+  META_TABLE_INIT_ERROR,
+  INCOMPATIBLE_VERSION,
+  INIT_LOGINS_ERROR,
+  INIT_STATS_ERROR,
+  MIGRATION_ERROR,
+  COMMIT_TRANSACTION_ERROR,
+
+  DATABASE_INIT_ERROR_COUNT,
+};
+
 void BindAddStatement(const PasswordForm& form,
                       const std::string& encrypted_password,
                       sql::Statement* s) {
   s->BindString(COLUMN_ORIGIN_URL, form.origin.spec());
   s->BindString(COLUMN_ACTION_URL, form.action.spec());
   s->BindString16(COLUMN_USERNAME_ELEMENT, form.username_element);
   s->BindString16(COLUMN_USERNAME_VALUE, form.username_value);
   s->BindString16(COLUMN_PASSWORD_ELEMENT, form.password_element);
   s->BindBlob(COLUMN_PASSWORD_VALUE, encrypted_password.data(),
               static_cast<int>(encrypted_password.length()));
@@ skipping 193 matching lines @@
 
 bool LoginDatabase::Init() {
   // Set pragmas for a small, private database (based on WebDatabase).
   db_.set_page_size(2048);
   db_.set_cache_size(32);
   db_.set_exclusive_locking();
   db_.set_restrict_to_user();
   db_.set_histogram_tag("Passwords");
 
   if (!db_.Open(db_path_)) {
+    UMA_HISTOGRAM_ENUMERATION("PasswordManager.LoginDatabaseInit",
+                              OPEN_FILE_ERROR, DATABASE_INIT_ERROR_COUNT);

[Ilya Sherman, 2015/08/13 00:34:18]

Please create a wrapper function for emitting to this histogram, so that you can
call it as "LogDatabaseInitError(OPEN_FILE_ERROR);".

[vasilii, 2015/08/13 09:04:33]

Done.

     LOG(ERROR) << "Unable to open the password store database.";
     return false;
   }
 
   sql::Transaction transaction(&db_);
   if (!transaction.Begin()) {
+    UMA_HISTOGRAM_ENUMERATION("PasswordManager.LoginDatabaseInit",
+                              START_TRANSACTION_ERROR,
+                              DATABASE_INIT_ERROR_COUNT);
     LOG(ERROR) << "Unable to start a transaction.";
     db_.Close();
     return false;
   }
 
   // Check the database version.
   if (!meta_table_.Init(&db_, kCurrentVersionNumber,
                         kCompatibleVersionNumber)) {
+    UMA_HISTOGRAM_ENUMERATION("PasswordManager.LoginDatabaseInit",
+                              META_TABLE_INIT_ERROR, DATABASE_INIT_ERROR_COUNT);
     LOG(ERROR) << "Unable to create the meta table.";
     db_.Close();
     return false;
   }
   if (meta_table_.GetCompatibleVersionNumber() > kCurrentVersionNumber) {
+    UMA_HISTOGRAM_ENUMERATION("PasswordManager.LoginDatabaseInit",
+                              INCOMPATIBLE_VERSION, DATABASE_INIT_ERROR_COUNT);
     LOG(ERROR) << "Password store database is too new, kCurrentVersionNumber="
                << kCurrentVersionNumber << ", GetCompatibleVersionNumber="
                << meta_table_.GetCompatibleVersionNumber();
     db_.Close();
     return false;
   }
 
   // Initialize the tables.
   if (!InitLoginsTable()) {
+    UMA_HISTOGRAM_ENUMERATION("PasswordManager.LoginDatabaseInit",
+                              INIT_LOGINS_ERROR, DATABASE_INIT_ERROR_COUNT);
     LOG(ERROR) << "Unable to initialize the logins table.";
     db_.Close();
     return false;
   }
 
   if (!stats_table_.Init(&db_)) {
+    UMA_HISTOGRAM_ENUMERATION("PasswordManager.LoginDatabaseInit",
+                              INIT_STATS_ERROR, DATABASE_INIT_ERROR_COUNT);
     LOG(ERROR) << "Unable to initialize the stats table.";
     db_.Close();
     return false;
   }
 
   // If the file on disk is an older database version, bring it up to date.
   if (!MigrateOldVersionsAsNeeded()) {
+    UMA_HISTOGRAM_ENUMERATION("PasswordManager.LoginDatabaseInit",
+                              MIGRATION_ERROR, DATABASE_INIT_ERROR_COUNT);
+    UMA_HISTOGRAM_CUSTOM_COUNTS("PasswordManager.LoginDatabaseFailedVersion",
+                                meta_table_.GetVersionNumber(), 1, 30, 30);

[Ilya Sherman, 2015/08/13 00:34:18]

nit: Would a sparse histogram be appropriate here?

[vasilii, 2015/08/13 09:04:33]

Done.

     LOG(ERROR) << "Unable to migrate database from "
                << meta_table_.GetVersionNumber() << " to "
                << kCurrentVersionNumber;
     db_.Close();
     return false;
   }
 
   if (!transaction.Commit()) {
+    UMA_HISTOGRAM_ENUMERATION("PasswordManager.LoginDatabaseInit",
+                              COMMIT_TRANSACTION_ERROR,
+                              DATABASE_INIT_ERROR_COUNT);
     LOG(ERROR) << "Unable to commit a transaction.";
     db_.Close();
     return false;
   }
 
   return true;
 }
 
 bool LoginDatabase::MigrateOldVersionsAsNeeded() {
   switch (meta_table_.GetVersionNumber()) {
@@ skipping 755 matching lines @@
     UMA_HISTOGRAM_ENUMERATION("PasswordManager.PslDomainMatchTriggering",
                               psl_domain_match_metric, PSL_DOMAIN_MATCH_COUNT);
   }
 
   if (!statement->Succeeded())
     return false;
   return true;
 }
 
 }  // namespace password_manager