tools/metrics/histograms/histograms.xml

Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 526cb57dbb41c4042c291f989aec1c4b980f1504..fe76c063501626170dbbff7b321828513a3032b9 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -28730,6 +28730,19 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
   </summary>
 </histogram>
 
+<histogram name="PasswordManager.LoginDatabaseFailedVersion">
+  <owner>vasilii@chromium.org</owner>
+  <summary>
+    The version of LoginDatabase if the migration to a new one failed.
+  </summary>
+</histogram>
+
+<histogram name="PasswordManager.LoginDatabaseInit"
+    enum="LoginDatabaseInitError">
+  <owner>vasilii@chromium.org</owner>
+  <summary>An error on LoginDatabase initialization.</summary>
+</histogram>
+
 <histogram name="PasswordManager.NumPasswordsDeletedByBulkDelete">
   <owner>vabr@chromium.org</owner>
   <summary>
@@ -62323,6 +62336,17 @@ To add a new entry, add it with any value and run test to compute valid value.
   <int value="2137599770" label="enable-win32k-renderer-lockdown"/>
 </enum>
 
+<enum name="LoginDatabaseInitError" type="int">
+  <int value="0" label="Can't open file"/>
+  <int value="1" label="Start transaction error"/>
+  <int value="2" label="Meta table failed initialization"/>
+  <int value="3" label="Incompatible current version"/>
+  <int value="4" label="Logins table failed initialization"/>
+  <int value="5" label="Stats table failed initialization"/>
+  <int value="6" label="Migration error"/>
+  <int value="7" label="Commit transaction error"/>
+</enum>

[Ilya Sherman, 2015/08/13 00:34:18]

When tracking errors, it's useful to include a bucket 0 that measures either "an
attempt was made" or "an attempt succeeded", so that you can compute an error
rate.  Otherwise, you can compare the frequency of errors relative to one
another, but you can't tell how frequently the operation fails overall.

[vasilii, 2015/08/13 09:04:33]

Done.

+
 <enum name="LoginFailureReason" type="int">
   <int value="0" label="NONE">None</int>
   <int value="1" label="COULD_NOT_MOUNT_CRYPTOHOME">