Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1574)

Issue 1284853002: Revert of [turbofan] Various fixes to allow unboxed doubles as arguments in registers... (Closed)

Created:
5 years, 4 months ago by Yang
Modified:
5 years, 4 months ago
Reviewers:
titzer, Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [turbofan] Various fixes to allow unboxed doubles as arguments in registers and on the stack. (patchset #7 id:120001 of https://codereview.chromium.org/1263033004/ ) Reason for revert: This CL breaks MIPS (roll blocker). https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20mipsel%20-%20sim/builds/2061/steps/Check/logs/Run_Int32_Select_1 Original issue's description: > [turbofan] Various fixes to allow unboxed doubles as arguments in registers and on the stack. > > R=jarin@chromium.org > BUG= > > Committed: https://crrev.com/71409be5395f867bbca0f6998bf6caa175cd8192 > Cr-Commit-Position: refs/heads/master@{#30091} TBR=jarin@chromium.org,titzer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/31a3f68da91084008a845bd6f7692dae3a0ec400 Cr-Commit-Position: refs/heads/master@{#30101}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+149 lines, -795 lines) Patch
M src/compiler/arm/code-generator-arm.cc View 4 chunks +15 lines, -9 lines 0 comments Download
M src/compiler/arm64/code-generator-arm64.cc View 4 chunks +15 lines, -10 lines 0 comments Download
M src/compiler/frame.h View 2 chunks +1 line, -7 lines 0 comments Download
M src/compiler/ia32/code-generator-ia32.cc View 2 chunks +16 lines, -11 lines 0 comments Download
M src/compiler/linkage.h View 1 chunk +3 lines, -2 lines 0 comments Download
M src/compiler/linkage.cc View 4 chunks +7 lines, -5 lines 0 comments Download
M src/compiler/machine-type.h View 1 chunk +0 lines, -5 lines 0 comments Download
M src/compiler/mips/code-generator-mips.cc View 4 chunks +13 lines, -10 lines 0 comments Download
M src/compiler/mips64/code-generator-mips64.cc View 4 chunks +13 lines, -10 lines 0 comments Download
M src/compiler/ppc/code-generator-ppc.cc View 3 chunks +14 lines, -8 lines 0 comments Download
M src/compiler/raw-machine-assembler.h View 1 chunk +5 lines, -8 lines 0 comments Download
M src/compiler/raw-machine-assembler.cc View 1 chunk +0 lines, -16 lines 0 comments Download
M src/compiler/register-allocator.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M src/compiler/register-allocator-verifier.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 3 chunks +16 lines, -15 lines 0 comments Download
M src/compiler/x87/code-generator-x87.cc View 3 chunks +17 lines, -11 lines 0 comments Download
M test/cctest/cctest.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/compiler/c-signature.h View 1 chunk +0 lines, -4 lines 0 comments Download
M test/cctest/compiler/call-tester.h View 1 chunk +0 lines, -15 lines 0 comments Download
M test/cctest/compiler/graph-builder-tester.h View 3 chunks +6 lines, -7 lines 0 comments Download
D test/cctest/compiler/test-run-native-calls.cc View 1 chunk +0 lines, -634 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Yang
Created Revert of [turbofan] Various fixes to allow unboxed doubles as arguments in registers and ...
5 years, 4 months ago (2015-08-11 06:48:05 UTC) #1
Jarin
5 years, 4 months ago (2015-08-11 06:53:47 UTC) #2
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698