Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1109)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/android/memdump/memdump.cc

Issue 1284833004: Remove remaining legacy SplitString calls. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chromecast/net/net_util_cast.cc ('K') | « third_party/mojo/src/mojo/edk/test/test_support_impl.cc ('k') | tools/gn/command_clean.cc » ('j') | tools/gn/command_refs.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/android/memdump/memdump.cc
diff --git a/tools/android/memdump/memdump.cc b/tools/android/memdump/memdump.cc
index 5ff459e4b5c25a2699bb16b91c861f1b6e080f46..a1b61049a045b0b65a30f7c2e3a089c02b1c7e6e 100644
--- a/tools/android/memdump/memdump.cc
+++ b/tools/android/memdump/memdump.cc
@@ -130,13 +130,13 @@ typedef base::hash_map<uint64, int> PFNMap;
bool ParseMemoryMapLine(const std::string& line,
std::vector<std::string>* tokens,
MemoryMap* memory_map) {
- tokens->clear();
- base::SplitString(line, ' ', tokens);
+ tokens = base::SplitString(
sky 2015/08/11 21:48:51 *tokens
+ line, " ", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);
if (tokens->size() < 2)
return false;
const std::string& addr_range = tokens->at(0);
- std::vector<std::string> range_tokens;
- base::SplitString(addr_range, '-', &range_tokens);
+ std::vector<std::string> range_tokens = base::SplitString(
+ addr_range, "-", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);
const std::string& start_address_token = range_tokens.at(0);
if (!base::HexStringToUInt64(start_address_token,
&memory_map->start_address)) {
« chromecast/net/net_util_cast.cc ('K') | « third_party/mojo/src/mojo/edk/test/test_support_impl.cc ('k') | tools/gn/command_clean.cc » ('j') | tools/gn/command_refs.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698