Chromium Code Reviews| Index: tools/gn/command_refs.cc |
| diff --git a/tools/gn/command_refs.cc b/tools/gn/command_refs.cc |
| index 961e2102c8fa851be622f9a5faa3659d85a1934d..968b0741759ba7431538d3e6be4b9bed19f19f9d 100644 |
| --- a/tools/gn/command_refs.cc |
| +++ b/tools/gn/command_refs.cc |
| @@ -408,7 +408,6 @@ int RunRefs(const std::vector<std::string>& args) { |
| if (args[i][0] == '@') { |
| // The argument is as a path to a response file. |
| std::string contents; |
| - std::vector<std::string> lines; |
| bool ret = base::ReadFileToString(UTF8ToFilePath(args[i].substr(1)), |
| &contents); |
| if (!ret) { |
| @@ -416,8 +415,8 @@ int RunRefs(const std::vector<std::string>& args) { |
| .PrintToStdout(); |
| return 1; |
| } |
| - base::SplitString(contents, '\n', &lines); |
| - for (const auto& line : lines) { |
| + for (const auto& line : base::SplitString( |
|
sky
2015/08/11 21:48:51
nit: auto->std::string (or StringPiece)
|
| + contents, "\n", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL)) { |
| if (!line.empty()) |
| inputs.push_back(line); |
| } |