Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2398)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chromecast/net/net_util_cast.cc

Issue 1284833004: Remove remaining legacy SplitString calls. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromecast/base/metrics/cast_metrics_helper.cc ('k') | chromeos/dbus/dbus_client_bundle.cc » ('j') | tools/android/memdump/memdump.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromecast/net/net_util_cast.cc
diff --git a/chromecast/net/net_util_cast.cc b/chromecast/net/net_util_cast.cc
index 6e688316c8a46e3c290d6ecd6aef857f2a89fb51..02aab69905169923d942897039b41af9ed32dee0 100644
--- a/chromecast/net/net_util_cast.cc
+++ b/chromecast/net/net_util_cast.cc
@@ -22,9 +22,9 @@ base::hash_set<std::string> GetIgnoredInterfaces() {
base::CommandLine* command_line = base::CommandLine::ForCurrentProcess();
base::CommandLine::StringType netifs_to_ignore_str =
command_line->GetSwitchValueNative(switches::kNetifsToIgnore);
- base::CommandLine::StringVector netifs_to_ignore_vector;
- base::SplitString(netifs_to_ignore_str, ',', &netifs_to_ignore_vector);
- for (const auto& netif : netifs_to_ignore_vector)
+ for (const auto& netif : base::SplitString(
sky 2015/08/11 21:48:51 nit: auto->std::string as it isn't much longer and
+ netifs_to_ignore_str, ",", base::TRIM_WHITESPACE,
+ base::SPLIT_WANT_ALL))
ignored_interfaces.insert(netif);
return ignored_interfaces;
« no previous file with comments | « chromecast/base/metrics/cast_metrics_helper.cc ('k') | chromeos/dbus/dbus_client_bundle.cc » ('j') | tools/android/memdump/memdump.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698