Issue 1284493003: Subzero: Misc fixes/cleanup.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1284493003: Subzero: Misc fixes/cleanup. (Closed)

Created:
5 years, 4 months ago by Jim Stichnoth

Modified:
5 years, 4 months ago

Reviewers:
jvoung (off chromium), Karl, ascull, John

CC:
native-client-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Subzero: Misc fixes/cleanup. 1. Fix MINIMAL build. (a) Add a void cast to a var only used in asserts. (b) Use "REQUIRES:" instead of "REQUIRES" in a .ll file. 2. Use StrError instead of StrDump for errors. 3. Use a lambda instead of a functor because C++11. 4. Explicit check for -filetype=obj in a non-dump-enabled build, to avoid cryptic downstream error messages. 5. Run "make format" which was neglected earlier. BUG= none R=kschimpf@google.com Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=992f91ddfeb7e68bdb51498194c2af7e9017aeb1

Patch Set 1 #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+29 lines, -14 lines)			Patch
M	src/IceCfgNode.cpp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/IceCompiler.cpp	View	3 chunks	+16 lines, -5 lines	0 comments	Download
M	src/IceInstARM32.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/IceRegAlloc.cpp	View	1 chunk	+3 lines, -5 lines	0 comments	Download
M	src/IceTargetLoweringX86BaseImpl.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests_lit/llvm2ice_tests/nacl-atomic-errors.ll	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	tests_lit/llvm2ice_tests/reorder-basic-blocks.ll	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests_lit/parse_errs/insertextract-err.ll	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	tests_lit/parse_errs/nacl-fake-intrinsic.ll	View	2 chunks	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Jim Stichnoth

5 years, 4 months ago (2015-08-10 18:18:44 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
992f91ddfeb7e68bdb51498194c2af7e9017aeb1 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages