Make GrDrawTarget::Caps ref counted and GrGLCaps derive from it.

Make GrDrawTarget::Caps ref counted and GrGLCaps derive from it.

Also rename GrDrawTarget::getCaps() -> GrDrawTarget::caps().
Committed: https://code.google.com/p/skia/source/detail?r=8364

[bsalomon, 2013-03-25 15:21:34]

The meat is in GrDrawTarget.h and GrGLCaps.h. Most of the rest of the files have
small trivial changes.

[robertphillips, 2013-03-25 15:34:09]

lgtm + 1 question

https://codereview.chromium.org/12843026/diff/9002/src/gpu/gl/GrGLContext.cpp
File src/gpu/gl/GrGLContext.cpp (right):

https://codereview.chromium.org/12843026/diff/9002/src/gpu/gl/GrGLContext.cpp...
src/gpu/gl/GrGLContext.cpp:16: fExtensions = ctxInfo.fExtensions;
Shouldn't there be a ref here?

[bsalomon, 2013-03-25 15:37:27]

https://codereview.chromium.org/12843026/diff/9002/src/gpu/gl/GrGLContext.cpp
File src/gpu/gl/GrGLContext.cpp (right):

https://codereview.chromium.org/12843026/diff/9002/src/gpu/gl/GrGLContext.cpp...
src/gpu/gl/GrGLContext.cpp:16: fExtensions = ctxInfo.fExtensions;
On 2013/03/25 15:34:09, robertphillips wrote:
> Shouldn't there be a ref here?

It's object assignment not pointer assignment. Since the object in
GrGLContextInfo is writable (and there is a writable pointer getter) it seemed
safer to make a copy. The GrGLContextInfo cons always calls new to create a new
GrGLCaps.

[bsalomon, 2013-03-25 15:38:52]

Committed patchset #2 manually as r8364 (presubmit successful).

[robertphillips, 2013-03-25 22:41:28]

https://codereview.chromium.org/12843026/diff/9002/src/gpu/gl/GrGLContext.cpp
File src/gpu/gl/GrGLContext.cpp (right):

https://codereview.chromium.org/12843026/diff/9002/src/gpu/gl/GrGLContext.cpp...
src/gpu/gl/GrGLContext.cpp:16: fExtensions = ctxInfo.fExtensions;
Okay - missed that when reading through. Does that mean that the caps object's
ref-counted-ness is never really used?

[bsalomon, 2013-03-26 12:42:00]

On 2013/03/25 22:41:28, robertphillips wrote:
> https://codereview.chromium.org/12843026/diff/9002/src/gpu/gl/GrGLContext.cpp
> File src/gpu/gl/GrGLContext.cpp (right):
> 
>
https://codereview.chromium.org/12843026/diff/9002/src/gpu/gl/GrGLContext.cpp...
> src/gpu/gl/GrGLContext.cpp:16: fExtensions = ctxInfo.fExtensions;
> Okay - missed that when reading through. Does that mean that the caps object's
> ref-counted-ness is never really used?

It's used in two places. GrGpuGL makes its GrDrawTarget::fCaps point at (and
ref) its fGLContext.info().caps(). Also, GrIODB makes its fCaps point at its
playback target fCaps.