Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1229)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1284143006: Update error message assertions for the new chooser. (Closed)

Created:
5 years, 4 months ago by Jeffrey Yasskin
Modified:
5 years, 3 months ago
Reviewers:
ortuno
CC:
blink-reviews, scheib+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@add-chooser-error
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Update error message assertions for the new chooser. And remove obsolete error messages. 3rd of 3 patches: 1. Add errors and prepare tests. (https://codereview.chromium.org/1293593003/) 2. Wire up the chooser on the Chrome side. (https://codereview.chromium.org/1286063002/) 3. This patch. BUG=500989 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201245

Patch Set 1 #

Patch Set 2 : Remove now-unused errors. #

Patch Set 3 : Remove NoBluetoothChooser, which turns out not to be used. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -16 lines) Patch
M LayoutTests/bluetooth/requestDevice.html View 1 2 3 chunks +3 lines, -6 lines 0 comments Download
M Source/modules/bluetooth/BluetoothError.cpp View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
M public/platform/modules/bluetooth/WebBluetoothError.h View 1 2 1 chunk +0 lines, -5 lines 0 comments Download

Depends on Patchset:

Issue 1293593003 Patch 20001

Messages

Total messages: 14 (7 generated)
ortuno
lgtm
5 years, 4 months ago (2015-08-17 21:15:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1284143006/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1284143006/40001
5 years, 3 months ago (2015-08-26 17:51:40 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/55198)
5 years, 3 months ago (2015-08-26 18:15:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1284143006/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1284143006/40001
5 years, 3 months ago (2015-08-26 18:28:07 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/103922)
5 years, 3 months ago (2015-08-26 19:11:50 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1284143006/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1284143006/40001
5 years, 3 months ago (2015-08-26 19:20:59 UTC) #13
commit-bot: I haz the power
5 years, 3 months ago (2015-08-26 20:36:22 UTC) #14
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201245

Powered by Google App Engine
This is Rietveld 408576698