Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Unified Diff: LayoutTests/bluetooth/requestDevice.html

Issue 1284143006: Update error message assertions for the new chooser. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@add-chooser-error
Patch Set: Remove NoBluetoothChooser, which turns out not to be used. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/modules/bluetooth/BluetoothError.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: LayoutTests/bluetooth/requestDevice.html
diff --git a/LayoutTests/bluetooth/requestDevice.html b/LayoutTests/bluetooth/requestDevice.html
index 08236bc2b68df842b8d51561e67c29ab4f97690e..834bc70756f228076fc087c42c09e290d99cef8e 100644
--- a/LayoutTests/bluetooth/requestDevice.html
+++ b/LayoutTests/bluetooth/requestDevice.html
@@ -27,8 +27,7 @@ promise_test(() => {
testRunner.setBluetoothMockDataSet('FailStartDiscoveryAdapter');
return assert_promise_rejects_with_message(
requestDeviceWithKeyDown({filters: [{services: ['generic_access']}]}),
- // TODO(jyasskin): Uncomment the message when it's changed on the Chrome side.
- {name: 'NotFoundError', /*message: 'User cancelled the requestDevice() chooser.'*/},
+ {name: 'NotFoundError', message: 'User cancelled the requestDevice() chooser.'},
'The adapter failed to start a discovery session.');
}, 'Discovery session fails to start.');
@@ -46,8 +45,7 @@ promise_test(() => {
testRunner.setBluetoothMockDataSet('NotPoweredAdapter');
return assert_promise_rejects_with_message(
requestDeviceWithKeyDown({filters: [{services: ['generic_access']}]}),
- // TODO(jyasskin): Uncomment the message when it's changed on the Chrome side.
- {name: 'NotFoundError', /*message: 'User cancelled the requestDevice() chooser.'*/},
+ {name: 'NotFoundError', message: 'User cancelled the requestDevice() chooser.'},
'Bluetooth adapter is not powered.');
}, 'Reject with NotFoundError if the adapter is off.');
@@ -57,8 +55,7 @@ promise_test(() => {
testRunner.setBluetoothMockDataSet('EmptyAdapter');
return assert_promise_rejects_with_message(
requestDeviceWithKeyDown({filters: [{services: ['generic_access']}]}),
- // TODO(jyasskin): Uncomment the message when it's changed on the Chrome side.
- {name: 'NotFoundError', /*message: 'User cancelled the requestDevice() chooser.'*/},
+ {name: 'NotFoundError', message: 'User cancelled the requestDevice() chooser.'},
'No Bluetooth devices in range.');
}, 'Reject with NotFoundError if there are no devices around.');
« no previous file with comments | « no previous file | Source/modules/bluetooth/BluetoothError.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698