Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 1293593003: Add errors for various chooser failure modes, and remove assertions that are about to change. (Closed)

Created:
5 years, 4 months ago by Jeffrey Yasskin
Modified:
5 years, 4 months ago
Reviewers:
scheib, ortuno
CC:
blink-reviews, dglazkov+blink, scheib+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@pinned
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add errors for various chooser failure modes, and remove assertions that are about to change. NoBluetoothChooser ChosenDeviceVanished ChooserCancelled 1st of 3 patches: 1. This patch. 2. Wire up the chooser on the Chrome side. (https://codereview.chromium.org/1286063002/) 3. Update the test assertions and remove now-unused errors. (https://codereview.chromium.org/1284143006/) BUG=500989 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201175

Patch Set 1 #

Patch Set 2 : Sync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -4 lines) Patch
M LayoutTests/bluetooth/requestDevice.html View 1 2 chunks +12 lines, -3 lines 0 comments Download
M LayoutTests/bluetooth/resources/bluetooth-helpers.js View 1 chunk +3 lines, -1 line 0 comments Download
M Source/modules/bluetooth/BluetoothError.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M public/platform/modules/bluetooth/WebBluetoothError.h View 1 chunk +3 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (5 generated)
Jeffrey Yasskin
5 years, 4 months ago (2015-08-14 22:54:53 UTC) #2
ortuno
lgtm
5 years, 4 months ago (2015-08-17 16:38:47 UTC) #3
scheib
LGTM
5 years, 4 months ago (2015-08-25 18:09:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1293593003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1293593003/1
5 years, 4 months ago (2015-08-25 23:28:57 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/61347) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 4 months ago (2015-08-25 23:30:43 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1293593003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1293593003/20001
5 years, 4 months ago (2015-08-25 23:35:48 UTC) #11
commit-bot: I haz the power
5 years, 4 months ago (2015-08-26 00:39:11 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201175

Powered by Google App Engine
This is Rietveld 408576698