Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1284073002: bluetooth: Add adapter to BluetoothDevice (Closed)

Created:
5 years, 4 months ago by scheib
Modified:
5 years, 3 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, extensions-reviews_chromium.org, jam, scheib+watch_chromium.org, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, mkwst+moarreviews-shell_chromium.org, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@bt-drop-callback-
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bluetooth: Add adapter to BluetoothDevice The base class BluetoothDevice::CreateGattConnection implementation requires access to the BluetoothAdapter. This patch updates all subclasses to provide it. Part of a 4 patch series: https://crrev.com/1287753002 Remove Disconnect callback https://crrev.com/1284073002 Add adapter_ to BluetoothDevice <<< https://crrev.com/1292263002 BluetoothDevice::CreateGattConnection Impl https://crrev.com/1256313002 Android Impl & tests. BUG=512643 Committed: https://crrev.com/eea0c48ed229131a6ce9fb61a883ae9272febe84 Cr-Commit-Position: refs/heads/master@{#349248}

Patch Set 1 : #

Patch Set 2 : Updated patchset dependency #

Total comments: 4

Patch Set 3 : Merge TOT #

Patch Set 4 : addressed jyasskin #

Patch Set 5 : Merge TOT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -78 lines) Patch
M chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_apitest.cc View 1 2 3 4 5 chunks +11 lines, -9 lines 0 comments Download
M components/proximity_auth/ble/bluetooth_low_energy_connection_unittest.cc View 1 2 3 4 3 chunks +7 lines, -4 lines 0 comments Download
M content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M device/bluetooth/bluetooth_adapter_android.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M device/bluetooth/bluetooth_adapter_mac.mm View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M device/bluetooth/bluetooth_adapter_mac_unittest.mm View 1 2 1 chunk +1 line, -1 line 0 comments Download
M device/bluetooth/bluetooth_adapter_win.cc View 1 2 1 chunk +2 lines, -5 lines 0 comments Download
M device/bluetooth/bluetooth_classic_device_mac.h View 1 chunk +4 lines, -1 line 0 comments Download
M device/bluetooth/bluetooth_classic_device_mac.mm View 1 chunk +4 lines, -3 lines 0 comments Download
M device/bluetooth/bluetooth_device.h View 1 2 3 chunks +6 lines, -1 line 0 comments Download
M device/bluetooth/bluetooth_device.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M device/bluetooth/bluetooth_device_android.h View 3 chunks +6 lines, -2 lines 0 comments Download
M device/bluetooth/bluetooth_device_android.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M device/bluetooth/bluetooth_device_chromeos.h View 1 2 3 2 chunks +1 line, -4 lines 0 comments Download
M device/bluetooth/bluetooth_device_chromeos.cc View 1 2 3 10 chunks +17 lines, -17 lines 0 comments Download
M device/bluetooth/bluetooth_device_mac.h View 2 chunks +3 lines, -1 line 0 comments Download
M device/bluetooth/bluetooth_device_mac.mm View 1 chunk +4 lines, -2 lines 0 comments Download
M device/bluetooth/bluetooth_device_win.h View 1 chunk +1 line, -0 lines 0 comments Download
M device/bluetooth/bluetooth_device_win.cc View 2 chunks +3 lines, -1 line 0 comments Download
M device/bluetooth/bluetooth_device_win_unittest.cc View 1 2 1 chunk +5 lines, -9 lines 0 comments Download
M device/bluetooth/bluetooth_low_energy_device_mac.h View 1 chunk +3 lines, -1 line 0 comments Download
M device/bluetooth/bluetooth_low_energy_device_mac.mm View 1 chunk +3 lines, -1 line 0 comments Download
M device/bluetooth/test/mock_bluetooth_device.cc View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M device/bluetooth/test/mock_bluetooth_gatt_connection.h View 1 chunk +4 lines, -1 line 0 comments Download
M device/bluetooth/test/mock_bluetooth_gatt_connection.cc View 1 2 3 1 chunk +5 lines, -1 line 0 comments Download

Depends on Patchset:

Issue 1287753002 Patch 100001

Dependent Patchsets:

Issue 1292263002 Patch 140001

Messages

Total messages: 17 (7 generated)
Jeffrey Yasskin
https://codereview.chromium.org/1284073002/diff/40001/device/bluetooth/bluetooth_device_chromeos.cc File device/bluetooth/bluetooth_device_chromeos.cc (right): https://codereview.chromium.org/1284073002/diff/40001/device/bluetooth/bluetooth_device_chromeos.cc#newcode129 device/bluetooth/bluetooth_device_chromeos.cc:129: adapter_(adapter), Would it make sense to remove this member, ...
5 years, 4 months ago (2015-08-19 22:19:04 UTC) #2
scheib
https://codereview.chromium.org/1284073002/diff/40001/device/bluetooth/bluetooth_device_chromeos.cc File device/bluetooth/bluetooth_device_chromeos.cc (right): https://codereview.chromium.org/1284073002/diff/40001/device/bluetooth/bluetooth_device_chromeos.cc#newcode129 device/bluetooth/bluetooth_device_chromeos.cc:129: adapter_(adapter), On 2015/08/19 22:19:04, Jeffrey Yasskin wrote: > Would ...
5 years, 3 months ago (2015-09-13 02:40:11 UTC) #5
Jeffrey Yasskin
lgtm
5 years, 3 months ago (2015-09-15 22:59:27 UTC) #6
scheib
armansito, OWNERS please.
5 years, 3 months ago (2015-09-15 23:07:19 UTC) #8
scheib
sacomoto@chromium.org: Please review changes in components/proximity_auth/ble/bluetooth_low_energy_connection_unittest.cc
5 years, 3 months ago (2015-09-15 23:14:02 UTC) #10
sacomoto
proximity_auth/ble LGTM.
5 years, 3 months ago (2015-09-16 17:27:24 UTC) #11
armansito
lgtm
5 years, 3 months ago (2015-09-16 19:58:58 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1284073002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1284073002/120001
5 years, 3 months ago (2015-09-16 21:38:44 UTC) #15
commit-bot: I haz the power
Committed patchset #5 (id:120001)
5 years, 3 months ago (2015-09-16 22:10:01 UTC) #16
commit-bot: I haz the power
5 years, 3 months ago (2015-09-16 22:11:10 UTC) #17
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/eea0c48ed229131a6ce9fb61a883ae9272febe84
Cr-Commit-Position: refs/heads/master@{#349248}

Powered by Google App Engine
This is Rietveld 408576698