bluetooth: Remove callback from BluetoothGattConnection::Disconnect

bluetooth: Remove callback from BluetoothGattConnection::Disconnect

In the process of implementing implement
BluetoothDevice::CreateGattConnection for Android and Mac platforms
we found a pattern mis match, where previously callbacks upon
actions such as disconnect were planned. However, Android and
CoreBluetooth APIs only send events with no contract for a 1:1
pairing with calls such as disconnecting.

Simplify our API by removing the BluetoothGattConnection::Disconnect
callback, as we don't need it.

Part of a 4 patch series:
https://crrev.com/1287753002 Remove Disconnect callback <<<
https://crrev.com/1284073002 Add adapter_ to BluetoothDevice
https://crrev.com/1292263002 BluetoothDevice::CreateGattConnection Impl
https://crrev.com/1256313002 Android Impl & tests.

BUG=520304
Committed: https://crrev.com/c89c898b165345923e5f36fd4dde886891d80211
Cr-Commit-Position: refs/heads/master@{#349233}

[scheib, 2015-08-12 23:49:10]

scheib@chromium.org changed reviewers:
+ armansito@chromium.org

[Jeffrey Yasskin, 2015-08-19 20:36:15]

The CQ bit was checked by jyasskin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-08-19 20:37:29]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1287753002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1287753002/20001

[Jeffrey Yasskin, 2015-08-19 20:43:46]

lgtm

https://codereview.chromium.org/1287753002/diff/20001/device/bluetooth/blueto...
File device/bluetooth/bluetooth_gatt_chromeos_unittest.cc (right):

https://codereview.chromium.org/1287753002/diff/20001/device/bluetooth/blueto...
device/bluetooth/bluetooth_gatt_chromeos_unittest.cc:211: EXPECT_EQ(1,
success_callback_count_--);
I think it'd be easier to read to assign success_callback_count_=0 on the next
line.

[commit-bot: I haz the power, 2015-08-19 21:43:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-19 21:43:16]

Dry run: This issue passed the CQ dry run.

[scheib, 2015-09-01 20:57:40]

Patchset #4 (id:60001) has been deleted

[scheib, 2015-09-01 20:57:46]

Patchset #1 (id:1) has been deleted

[scheib, 2015-09-13 02:39:57]

https://codereview.chromium.org/1287753002/diff/20001/device/bluetooth/blueto...
File device/bluetooth/bluetooth_gatt_chromeos_unittest.cc (right):

https://codereview.chromium.org/1287753002/diff/20001/device/bluetooth/blueto...
device/bluetooth/bluetooth_gatt_chromeos_unittest.cc:211: EXPECT_EQ(1,
success_callback_count_--);
On 2015/08/19 20:43:46, Jeffrey Yasskin wrote:
> I think it'd be easier to read to assign success_callback_count_=0 on the next
> line.

I think the extra lines and code dilute the test intent. I've reverted to
previous style.

[scheib, 2015-09-14 03:54:40]

arman for OWNERS please.

[armansito, 2015-09-16 19:51:48]

lgtm

[scheib, 2015-09-16 20:49:37]

The CQ bit was checked by scheib@chromium.org

[scheib, 2015-09-16 20:49:37]

The patchset sent to the CQ was uploaded after l-g-t-m from
jyasskin@chromium.org
Link to the patchset: https://codereview.chromium.org/1287753002/#ps100001
(title: "Merge TOT")

[commit-bot: I haz the power, 2015-09-16 20:50:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1287753002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1287753002/100001

[commit-bot: I haz the power, 2015-09-16 21:26:26]

Committed patchset #4 (id:100001)

[commit-bot: I haz the power, 2015-09-16 21:27:05]

Patchset 4 (id:??) landed as
https://crrev.com/c89c898b165345923e5f36fd4dde886891d80211
Cr-Commit-Position: refs/heads/master@{#349233}