device/bluetooth/test/mock_bluetooth_gatt_connection.cc - Issue 1284073002: bluetooth: Add adapter to BluetoothDevice

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: device/bluetooth/test/mock_bluetooth_gatt_connection.cc

Issue 1284073002: bluetooth: Add adapter to BluetoothDevice (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bt-drop-callback-

Patch Set: Updated patchset dependency Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« device/bluetooth/bluetooth_device_chromeos.cc ('K') | « device/bluetooth/test/mock_bluetooth_gatt_connection.h ('k') | extensions/browser/api/bluetooth_low_energy/bluetooth_low_energy_apitest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "device/bluetooth/test/mock_bluetooth_gatt_connection.h"	5 #include "device/bluetooth/test/mock_bluetooth_gatt_connection.h"

6	6

	7 #include "device/bluetooth/bluetooth_adapter.h"

	8

7 using ::testing::Return;	9 using ::testing::Return;

8	10

9 namespace device {	11 namespace device {

10	12

11 MockBluetoothGattConnection::MockBluetoothGattConnection(	13 MockBluetoothGattConnection::MockBluetoothGattConnection(

12 const std::string& device_address) {	14 scoped_refptr<device::BluetoothAdapter> adapter,

	15 const std::string& device_address)

	16 : BluetoothGattConnection(/* Next Patch: adapter.get(), device_address */) {
	Jeffrey Yasskin 2015/08/19 22:19:04 Just \|adapter\|. .get() risks holding a pointer to Just \|adapter\|. .get() risks holding a pointer to a dead object. scheib 2015/09/13 02:40:11 Done. Show quoted text On 2015/08/19 22:19:04, Jeffrey Yasskin wrote: > Just \|adapter\|. .get() risks holding a pointer to a dead object. Done.
13 ON_CALL(*this, GetDeviceAddress()).WillByDefault(Return(device_address));	17 ON_CALL(*this, GetDeviceAddress()).WillByDefault(Return(device_address));

14 ON_CALL(*this, IsConnected()).WillByDefault(Return(true));	18 ON_CALL(*this, IsConnected()).WillByDefault(Return(true));

15 }	19 }

16	20

17 MockBluetoothGattConnection::~MockBluetoothGattConnection() {}	21 MockBluetoothGattConnection::~MockBluetoothGattConnection() {}

18	22

19 } // namespace device	23 } // namespace device

OLD	NEW