Remove effective zoom from font metrics before length calculations

Remove effective zoom from font metrics before length calculations

Since https://codereview.chromium.org/308123010 and
https://codereview.chromium.org/323053002, the effectiveZoom is
included in the style's font. This patch adds missing code to
SVGLengthContext to remove the effective zoom before computing ex
(x-height) and ch (zero-width) units.

BUG=519133
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200393

[davve, 2015-08-11 12:40:21]

davve@opera.com changed reviewers:
+ fs@opera.com, pdr@chromium.org

[davve, 2015-08-11 12:40:22]

Nice hole I've dug myself here...

https://codereview.chromium.org/1081813003 took care of
core/layout/svg but the ones in core/svg slipped by.

Actions taken to find other cases:

 * I've looked for others users of fontMetrics in core/svg.

 * I've also looked for users of
   ComputedStyle::computedFontSize(), ComputedStyle::fontSize()
   in SVG but came up empty.

Any more you can think of?

[fs, 2015-08-11 12:50:05]

On 2015/08/11 12:40:22, David Vest wrote:
> Nice hole I've dug myself here...
> 
> https://codereview.chromium.org/1081813003 took care of
> core/layout/svg but the ones in core/svg slipped by.
> 
> Actions taken to find other cases:
> 
>  * I've looked for others users of fontMetrics in core/svg.
> 
>  * I've also looked for users of
>    ComputedStyle::computedFontSize(), ComputedStyle::fontSize()
>    in SVG but came up empty.
> 
> Any more you can think of?

Not straight off the bat - maybe pdr can.

Anyway, LGTM.

[pdr., 2015-08-11 19:59:30]

On 2015/08/11 at 12:50:05, fs wrote:
> On 2015/08/11 12:40:22, David Vest wrote:
> > Nice hole I've dug myself here...
> > 
> > https://codereview.chromium.org/1081813003 took care of
> > core/layout/svg but the ones in core/svg slipped by.
> > 
> > Actions taken to find other cases:
> > 
> >  * I've looked for others users of fontMetrics in core/svg.
> > 
> >  * I've also looked for users of
> >    ComputedStyle::computedFontSize(), ComputedStyle::fontSize()
> >    in SVG but came up empty.
> > 
> > Any more you can think of?
> 
> Not straight off the bat - maybe pdr can.
> 
> Anyway, LGTM.

Codechange LGTM as well but it looks like the test needs a little cleanup to
pass on windows.

[davve, 2015-08-12 07:57:45]

The CQ bit was checked by davve@opera.com

[davve, 2015-08-12 07:57:45]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org,
fs@opera.com
Link to the patchset: https://codereview.chromium.org/1283463003/#ps20001
(title: "Avoid hardcoded values in test")

[commit-bot: I haz the power, 2015-08-12 07:57:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1283463003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1283463003/20001

[commit-bot: I haz the power, 2015-08-12 09:24:00]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200393