Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 1283463003: Remove effective zoom from font metrics before length calculations (Closed)

Created:
5 years, 4 months ago by davve
Modified:
5 years, 4 months ago
Reviewers:
pdr., fs
CC:
blink-reviews, krit, kouhei+svg_chromium.org, f(malita), gyuyoung2, Stephen Chennney, pdr+svgwatchlist_chromium.org, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove effective zoom from font metrics before length calculations Since https://codereview.chromium.org/308123010 and https://codereview.chromium.org/323053002, the effectiveZoom is included in the style's font. This patch adds missing code to SVGLengthContext to remove the effective zoom before computing ex (x-height) and ch (zero-width) units. BUG=519133 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200393

Patch Set 1 #

Patch Set 2 : Avoid hardcoded values in test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -4 lines) Patch
A LayoutTests/svg/custom/zoomed-ex-em-font-sizes.html View 1 1 chunk +40 lines, -0 lines 0 comments Download
M Source/core/svg/SVGLengthContext.cpp View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
davve
Nice hole I've dug myself here... https://codereview.chromium.org/1081813003 took care of core/layout/svg but the ones in ...
5 years, 4 months ago (2015-08-11 12:40:22 UTC) #2
fs
On 2015/08/11 12:40:22, David Vest wrote: > Nice hole I've dug myself here... > > ...
5 years, 4 months ago (2015-08-11 12:50:05 UTC) #3
pdr.
On 2015/08/11 at 12:50:05, fs wrote: > On 2015/08/11 12:40:22, David Vest wrote: > > ...
5 years, 4 months ago (2015-08-11 19:59:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1283463003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1283463003/20001
5 years, 4 months ago (2015-08-12 07:57:49 UTC) #7
commit-bot: I haz the power
5 years, 4 months ago (2015-08-12 09:24:00 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200393

Powered by Google App Engine
This is Rietveld 408576698