Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1081813003: Remove effective zoom from font metrics before SVG text layout. (Closed)

Created:
5 years, 8 months ago by davve
Modified:
5 years, 8 months ago
CC:
blink-reviews, blink-reviews-rendering, zoltan1, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, kouhei+svg_chromium.org, fs, Dominik Röttsches, ed+blinkwatch_opera.com, krit, f(malita), jchaffraix+rendering, gyuyoung2, Stephen Chennney, rwlbuis, pdr+svgwatchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove effective zoom from font metrics before SVG text layout. Since https://codereview.chromium.org/308123010 and https://codereview.chromium.org/323053002, the effectiveZoom is included in the style's font. This patch adds missing code to SVGTextLayoutEngineBaseline to remove the effective zoom before computing baseline and advance. BUG=476344 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193786

Patch Set 1 #

Patch Set 2 : Added tests #

Total comments: 2

Patch Set 3 : Address review comments #

Patch Set 4 : Try SVG DOM in tests to see if it behaves better on Windows #

Patch Set 5 : Yet another test more closely matching the bug report; other tests disabled on Windows for now #

Patch Set 6 : Update expectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+214 lines, -15 lines) Patch
M LayoutTests/TestExpectations View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
A LayoutTests/svg/custom/zoomed-alignment-baseline.html View 1 2 3 1 chunk +48 lines, -0 lines 0 comments Download
A LayoutTests/svg/custom/zoomed-alignment-baseline-expected.txt View 1 2 1 chunk +39 lines, -0 lines 0 comments Download
A LayoutTests/svg/custom/zoomed-baseline-shift.html View 1 2 3 1 chunk +33 lines, -0 lines 0 comments Download
A LayoutTests/svg/custom/zoomed-baseline-shift-expected.txt View 1 2 3 4 5 1 chunk +18 lines, -0 lines 0 comments Download
A LayoutTests/svg/custom/zoomed-mixed-scripts.html View 1 2 3 4 1 chunk +35 lines, -0 lines 0 comments Download
A LayoutTests/svg/custom/zoomed-mixed-scripts-expected.txt View 1 2 3 4 1 chunk +9 lines, -0 lines 0 comments Download
M Source/core/layout/svg/SVGTextLayoutEngine.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/svg/SVGTextLayoutEngineBaseline.h View 1 2 3 4 2 chunks +6 lines, -1 line 0 comments Download
M Source/core/layout/svg/SVGTextLayoutEngineBaseline.cpp View 1 2 5 chunks +22 lines, -13 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Erik Dahlström (inactive)
lgtm https://codereview.chromium.org/1081813003/diff/20001/Source/core/layout/svg/SVGTextLayoutEngineBaseline.cpp File Source/core/layout/svg/SVGTextLayoutEngineBaseline.cpp (right): https://codereview.chromium.org/1081813003/diff/20001/Source/core/layout/svg/SVGTextLayoutEngineBaseline.cpp#newcode120 Source/core/layout/svg/SVGTextLayoutEngineBaseline.cpp:120: float alignementBaselineShift = 0; s/alignement/alignment/
5 years, 8 months ago (2015-04-14 09:13:08 UTC) #2
fs
lgtm https://codereview.chromium.org/1081813003/diff/20001/Source/core/layout/svg/SVGTextLayoutEngineBaseline.cpp File Source/core/layout/svg/SVGTextLayoutEngineBaseline.cpp (right): https://codereview.chromium.org/1081813003/diff/20001/Source/core/layout/svg/SVGTextLayoutEngineBaseline.cpp#newcode154 Source/core/layout/svg/SVGTextLayoutEngineBaseline.cpp:154: alignementBaselineShift = alignementBaselineShift / m_effectiveZoom; Since we have ...
5 years, 8 months ago (2015-04-14 09:21:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1081813003/100001
5 years, 8 months ago (2015-04-15 12:31:58 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-15 12:35:24 UTC) #8
Message was sent while issue was closed. 
Committed patchset #6 (id:100001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193786

Powered by Google App Engine
This is Rietveld 408576698