Unapply effectiveZoom during SVG layout

Unapply effectiveZoom during SVG layout

Text layout in SVG is assumed to happen in unzoomed coordinates.
Prior to this patch, there was a special SVG mode in the
StyleResolver that disregarded zoom when resolving lengths for
SVG elements. That broke down during inheritance though, so a
better way to handle the SVG zoom model is for the SVG module to
remove zoom from style values itself.

BUG=382366
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176051

[davve, 2014-06-12 09:29:32]

Couldn't resist attempting at the last user of  useSVGZoomState. I don't
necessarily think we end up in a good place (having to unapply zoom from style
values is quite ugly) but luckily it's really rare. Perhaps we can find out a
better way to handle zoom going forward.

[fs, 2014-06-12 10:54:32]

On 2014/06/12 09:29:32, David Vest wrote:
> Couldn't resist attempting at the last user of  useSVGZoomState. I don't
> necessarily think we end up in a good place (having to unapply zoom from style
> values is quite ugly) but luckily it's really rare. Perhaps we can find out a
> better way to handle zoom going forward.

This looks like a disaster in the right direction, but I'll leave it to pdr to
L-G-T-M.

[pdr., 2014-06-12 17:42:29]

On 2014/06/12 10:54:32, fs wrote:
> On 2014/06/12 09:29:32, David Vest wrote:
> > Couldn't resist attempting at the last user of  useSVGZoomState. I don't
> > necessarily think we end up in a good place (having to unapply zoom from
style
> > values is quite ugly) but luckily it's really rare. Perhaps we can find out
a
> > better way to handle zoom going forward.
> 
> This looks like a disaster in the right direction, but I'll leave it to pdr to
> L-G-T-M.

It may be Stockholm syndrome but I don't think this is so bad ;)

Nice cleanup.

LGTM

[pdr., 2014-06-12 17:42:34]

The CQ bit was checked by pdr@chromium.org

[commit-bot: I haz the power, 2014-06-12 17:43:02]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/davve@opera.com/323053002/20001

[commit-bot: I haz the power, 2014-06-12 21:34:00]

Change committed as 176051