Issue 12834012: Update code to use helper function for better readability/searching.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12834012: Update code to use helper function for better readability/searching. (Closed)

Created:
7 years, 9 months ago by djsollen

Modified:
7 years, 9 months ago

Reviewers:
reed1

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

Update code to use helper function for better readability/searching. Committed: https://code.google.com/p/skia/source/detail?r=8287

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -9 lines)			Patch
M	src/images/SkImageDecoder_libbmp.cpp	View	1 chunk	+3 lines, -4 lines	0 comments	Download
M	src/images/SkImageDecoder_libico.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/ports/SkFontHost_FreeType.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/ports/SkXMLParser_expat.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/ports/SkXMLParser_tinyxml.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/ports/SkXMLPullParser_expat.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

reed1

lgtm I'm starting to think we *can* get rid of getLength(), and replace it with ...

7 years, 9 months ago (2013-03-21 13:28:31 UTC) #2

djsollen

7 years, 9 months ago (2013-03-21 13:31:06 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r8287 (presubmit successful).