src/images/SkImageDecoder_libico.cpp - Issue 12834012: Update code to use helper function for better readability/searching.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/images/SkImageDecoder_libico.cpp

Issue 12834012: Update code to use helper function for better readability/searching. (Closed) Base URL: https://skia.googlecode.com/svn/trunk

Patch Set: Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/images/SkImageDecoder_libico.cpp

diff --git a/src/images/SkImageDecoder_libico.cpp b/src/images/SkImageDecoder_libico.cpp

index 14f575babab4162f9db3706e6350af9479692a1c..ffc59e0003e1ca6706f3ea985cab37d680fdc432 100644

--- a/src/images/SkImageDecoder_libico.cpp

+++ b/src/images/SkImageDecoder_libico.cpp

@@ -75,7 +75,7 @@ static int calculateRowBytesFor8888(int w, int bitCount)

bool SkICOImageDecoder::onDecode(SkStream* stream, SkBitmap* bm, Mode mode)

{

- size_t length = stream->read(NULL, 0);

+ size_t length = stream->getLength();

SkAutoMalloc autoMal(length);

unsigned char* buf = (unsigned char*)autoMal.get();

if (stream->read((void*)buf, length) != length) {

« no previous file with comments | « src/images/SkImageDecoder_libbmp.cpp ('k') | src/ports/SkFontHost_FreeType.cpp » ('j') | no next file with comments »