src/ports/SkXMLPullParser_expat.cpp - Issue 12834012: Update code to use helper function for better readability/searching.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ports/SkXMLPullParser_expat.cpp

Issue 12834012: Update code to use helper function for better readability/searching. (Closed) Base URL: https://skia.googlecode.com/svn/trunk

Patch Set: Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ports/SkXMLPullParser_expat.cpp

diff --git a/src/ports/SkXMLPullParser_expat.cpp b/src/ports/SkXMLPullParser_expat.cpp

index 1d1615bcdcc78e414b40dc40a27d7717e247d0be..44a3c7f81eae0f75d3507660b2c348613df49e81 100644

--- a/src/ports/SkXMLPullParser_expat.cpp

+++ b/src/ports/SkXMLPullParser_expat.cpp

@@ -152,7 +152,7 @@ bool SkXMLPullParser::onInit()

XML_SetCharacterDataHandler(p, text_proc);

XML_SetUserData(p, &fImpl->fData);

- size_t len = fStream->read(NULL, 0);

+ size_t len = fStream->getLength();

fImpl->fBufferLen = len;

fImpl->fBuffer = sk_malloc_throw(len);

fStream->rewind();

« no previous file with comments | « src/ports/SkXMLParser_tinyxml.cpp ('k') | no next file » | no next file with comments »