content/browser/service_worker/service_worker_context_wrapper.cc - Issue 1283273002: Service Worker: Change last update check location and HTTP cache bypass rule (2/2)

Unified Diff: content/browser/service_worker/service_worker_context_wrapper.cc

Issue 1283273002: Service Worker: Change last update check location and HTTP cache bypass rule (2/2) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address the latest spec change. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/service_worker/service_worker_context_core.h ('K') | « content/browser/service_worker/service_worker_context_core.h ('k') | content/browser/service_worker/service_worker_dispatcher_host.cc » ('j') | content/browser/service_worker/service_worker_write_to_cache_job.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_context_wrapper.cc

diff --git a/content/browser/service_worker/service_worker_context_wrapper.cc b/content/browser/service_worker/service_worker_context_wrapper.cc

index 4c80be97e106c01abeeb1cf1efee7ebfc120d757..3dd2ee99f3329956c88c8bdce23c15dd194ce5f0 100644

--- a/content/browser/service_worker/service_worker_context_wrapper.cc

+++ b/content/browser/service_worker/service_worker_context_wrapper.cc

@@ -390,7 +390,7 @@ void ServiceWorkerContextWrapper::DidFindRegistrationForUpdate(

return;

DCHECK(registration);

context_core_->UpdateServiceWorker(registration.get(),

- true /* force_bypass_cache */);

+ false /* force_bypass_cache */);

nhiroki 2015/09/07 07:05:59 This should be true because this function is calle

jungkees 2015/09/08 16:01:13 I wanted to have your comment on this indeed. So,

nhiroki 2015/09/09 08:27:48 A separate CL should be OK. Can you leave a TODO c

jungkees 2015/09/09 13:13:37 Done.

}

namespace {