Service Worker: Change last update check location and HTTP cache bypass rule (2/2)

content/browser/service_worker/service_worker_context_wrapper.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/service_worker/service_worker_context_wrapper.h"
 
 #include <map>
 #include <set>
 #include <string>
 #include <vector>
@@ skipping 372 matching lines @@
     ServiceWorkerStatusCode status,
     const scoped_refptr<ServiceWorkerRegistration>& registration) {
   DCHECK_CURRENTLY_ON(BrowserThread::IO);
 
   if (status != SERVICE_WORKER_OK)
     return;
   if (!context_core_)
     return;
   DCHECK(registration);
   context_core_->UpdateServiceWorker(registration.get(),
-                                     true /* force_bypass_cache */);
+                                     false /* force_bypass_cache */);

[nhiroki, 2015/09/07 07:05:59]

This should be true because this function is called from a 'update' button on
DevTools which expects that the cache is bypassed (sorry, we should have added a
comment about it...)

To clarify this behavior, probably SWContextWrapper::UpdateRegistration() should
receive |force_bypass_cache| flag as a parameter and convey it up to here.

[jungkees, 2015/09/08 16:01:13]

I wanted to have your comment on this indeed. So, I set it to true as suggested.
Is it better to include that plumbing as part of this patch or a separate one?
Please let me know.

[nhiroki, 2015/09/09 08:27:48]

A separate CL should be OK. Can you leave a TODO comment here?

[jungkees, 2015/09/09 13:13:37]

Done.

 }
 
 namespace {
 void StatusCodeToBoolCallbackAdapter(
     const ServiceWorkerContext::ResultCallback& callback,
     ServiceWorkerStatusCode code) {
   callback.Run(code == ServiceWorkerStatusCode::SERVICE_WORKER_OK);
 }
 
 void EmptySuccessCallback(bool success) {
@@ skipping 226 matching lines @@
   observer_list_->Notify(FROM_HERE,
                          &ServiceWorkerContextObserver::OnStorageWiped);
 }
 
 ServiceWorkerContextCore* ServiceWorkerContextWrapper::context() {
   DCHECK_CURRENTLY_ON(BrowserThread::IO);
   return context_core_.get();
 }
 
 }  // namespace content