content/browser/service_worker/service_worker_context_core.h - Issue 1283273002: Service Worker: Change last update check location and HTTP cache bypass rule (2/2)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_context_core.h

Issue 1283273002: Service Worker: Change last update check location and HTTP cache bypass rule (2/2) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address the latest spec change. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/embedded_worker_instance.h ('k') | content/browser/service_worker/service_worker_context_wrapper.cc » ('j') | content/browser/service_worker/service_worker_context_wrapper.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_context_core.h

diff --git a/content/browser/service_worker/service_worker_context_core.h b/content/browser/service_worker/service_worker_context_core.h

index 4748aa965ad551025e9319ad7dfaf6b9985100d0..089c9616ffdb0c09adcf4b2398ae484317283ba6 100644

--- a/content/browser/service_worker/service_worker_context_core.h

+++ b/content/browser/service_worker/service_worker_context_core.h

@@ -183,6 +183,9 @@ class CONTENT_EXPORT ServiceWorkerContextCore

// if any did not succeed.

void UnregisterServiceWorkers(const GURL& origin,

const UnregistrationCallback& callback);

+ // Updates the service worker. If |force_bypass_cache| is true or 86400

nhiroki 2015/09/07 07:05:59 nit: Can you insert a blank line as a separator be

jungkees 2015/09/08 16:01:13 Done.

+ // seconds (24 hours) have passed since the last update, bypasses the browser

+ // cache.

void UpdateServiceWorker(ServiceWorkerRegistration* registration,

bool force_bypass_cache);

void UpdateServiceWorker(ServiceWorkerRegistration* registration,