Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Unified Diff: BUILD.gn

Issue 1283133002: Fix some gn_visibility TODOs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index 6bde7c0e2bdeaf735027cf86f4823d0ceab66c1c..8cbfd549b7060a84efed26603b2648c7a3daae8b 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -471,8 +471,8 @@ group("both_gn_and_gyp") {
"//ui/snapshot:snapshot_unittests",
"//ui/views/examples:views_examples_with_content_exe",
- # "//v8:v8_snapshot", # TODO(GYP): visibility?
- # "//v8:postmortem-metadata", # TODO(GYP): visibility?
+ "//v8:v8_snapshot",
+ "//v8:postmortem-metadata",
Dirk Pranke 2015/08/12 19:03:18 You shouldn't list these targets in two places (an
tfarina 2015/08/12 19:17:44 yep, bot caught this as well. Removed.
"//third_party/codesighs:nm2tsv",
"//third_party/sqlite:sqlite_shell",
@@ -742,8 +742,8 @@ group("gn_visibility") {
"//ui/resources:repack_ui_test_mac_locale_pack",
- # "//v8:v8_snapshot", # TODO(GYP): visibility?
- # "//v8:postmortem-metadata", # TODO(GYP): visibility?
+ "//v8:v8_snapshot",
+ "//v8:postmortem-metadata",
]
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698