Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Side by Side Diff: BUILD.gn

Issue 1283133002: Fix some gn_visibility TODOs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # This is the root build file for GN. GN will start processing by loading this 5 # This is the root build file for GN. GN will start processing by loading this
6 # file, and recursively load all dependencies until all dependencies are either 6 # file, and recursively load all dependencies until all dependencies are either
7 # resolved or known not to exist (which will cause the build to fail). So if 7 # resolved or known not to exist (which will cause the build to fail). So if
8 # you add a new build file, there must be some path of dependencies from this 8 # you add a new build file, there must be some path of dependencies from this
9 # file to your new one or GN won't know about it. 9 # file to your new one or GN won't know about it.
10 10
(...skipping 453 matching lines...) Expand 10 before | Expand all | Expand 10 after
464 "//sync/tools:sync_client", 464 "//sync/tools:sync_client",
465 "//sync/tools:sync_listen_notifications", 465 "//sync/tools:sync_listen_notifications",
466 "//testing/gmock:gmock_main", 466 "//testing/gmock:gmock_main",
467 "//third_party/mojo/src/mojo/edk/test:mojo_public_system_perftests", 467 "//third_party/mojo/src/mojo/edk/test:mojo_public_system_perftests",
468 "//tools/perf/clear_system_cache", 468 "//tools/perf/clear_system_cache",
469 "//ui/keyboard:keyboard_unittests", 469 "//ui/keyboard:keyboard_unittests",
470 "//ui/message_center:message_center_unittests", 470 "//ui/message_center:message_center_unittests",
471 "//ui/snapshot:snapshot_unittests", 471 "//ui/snapshot:snapshot_unittests",
472 "//ui/views/examples:views_examples_with_content_exe", 472 "//ui/views/examples:views_examples_with_content_exe",
473 473
474 # "//v8:v8_snapshot", # TODO(GYP): visibility? 474 "//v8:v8_snapshot",
475 # "//v8:postmortem-metadata", # TODO(GYP): visibility? 475 "//v8:postmortem-metadata",
Dirk Pranke 2015/08/12 19:03:18 You shouldn't list these targets in two places (an
tfarina 2015/08/12 19:17:44 yep, bot caught this as well. Removed.
476 476
477 "//third_party/codesighs:nm2tsv", 477 "//third_party/codesighs:nm2tsv",
478 "//third_party/sqlite:sqlite_shell", 478 "//third_party/sqlite:sqlite_shell",
479 ] 479 ]
480 480
481 if (current_toolchain == host_toolchain) { 481 if (current_toolchain == host_toolchain) {
482 # Do not build the breakpad utilities in cross-compiles. 482 # Do not build the breakpad utilities in cross-compiles.
483 deps += [ 483 deps += [
484 "//breakpad:dump_syms", 484 "//breakpad:dump_syms",
485 "//breakpad:microdump_stackwalk", 485 "//breakpad:microdump_stackwalk",
(...skipping 249 matching lines...) Expand 10 before | Expand all | Expand 10 after
735 735
736 group("gn_visibility") { 736 group("gn_visibility") {
737 deps = [ 737 deps = [
738 "//build/config/sanitizers:options_sources", 738 "//build/config/sanitizers:options_sources",
739 739
740 # "//third_party/pdfium:pdfium_embeddertests", # TODO(GYP): visibility? 740 # "//third_party/pdfium:pdfium_embeddertests", # TODO(GYP): visibility?
741 # "//third_party/pdfium:pdfium_unittests", # TODO(GYP): visibility? 741 # "//third_party/pdfium:pdfium_unittests", # TODO(GYP): visibility?
742 742
743 "//ui/resources:repack_ui_test_mac_locale_pack", 743 "//ui/resources:repack_ui_test_mac_locale_pack",
744 744
745 # "//v8:v8_snapshot", # TODO(GYP): visibility? 745 "//v8:v8_snapshot",
746 # "//v8:postmortem-metadata", # TODO(GYP): visibility? 746 "//v8:postmortem-metadata",
747 ] 747 ]
748 } 748 }
749 749
750 if (!is_ios) { 750 if (!is_ios) {
751 # This group includes all of the targets needed to build and test Blink, 751 # This group includes all of the targets needed to build and test Blink,
752 # including running the layout tests (see below). 752 # including running the layout tests (see below).
753 group("blink_tests") { 753 group("blink_tests") {
754 testonly = true 754 testonly = true
755 755
756 deps = [ 756 deps = [
(...skipping 175 matching lines...) Expand 10 before | Expand all | Expand 10 after
932 "//ui/views:views_unittests", # TooltipControllerTest failures 932 "//ui/views:views_unittests", # TooltipControllerTest failures
933 "//ui/wm:wm_unittests", # PASSES 4/21/2015 933 "//ui/wm:wm_unittests", # PASSES 4/21/2015
934 "//url:url_unittests", # PASSES 4/17/2015 934 "//url:url_unittests", # PASSES 4/17/2015
935 935
936 # TODO(GYP) nacl_integration 936 # TODO(GYP) nacl_integration
937 # TODO(GYP) telemetry_perf_unittests 937 # TODO(GYP) telemetry_perf_unittests
938 # TODO(GYP) telemetry_unittests 938 # TODO(GYP) telemetry_unittests
939 ] 939 ]
940 } 940 }
941 } 941 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698