Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 1283133002: Fix some gn_visibility TODOs. (Closed)

Created:
5 years, 4 months ago by tfarina
Modified:
5 years, 4 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix some gn_visibility TODOs. Tested on Mac with the following command lines: $ gn gen out-gn/Release --args='is_debug=false is_component_build=false symbol_level=1' $ ninja -C out-gn/Release gn_visibility BUG=504076 TEST=see above R=dpranke@chromium.org Committed: https://crrev.com/5132ba00872ecc7a9f1a71238bf390e09359ff5b Cr-Commit-Position: refs/heads/master@{#343120}

Patch Set 1 #

Total comments: 2

Patch Set 2 : only one #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M BUILD.gn View 1 2 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (1 generated)
tfarina
Is this correct?
5 years, 4 months ago (2015-08-12 02:55:01 UTC) #1
Dirk Pranke
lgtm https://codereview.chromium.org/1283133002/diff/1/BUILD.gn File BUILD.gn (right): https://codereview.chromium.org/1283133002/diff/1/BUILD.gn#newcode475 BUILD.gn:475: "//v8:postmortem-metadata", You shouldn't list these targets in two ...
5 years, 4 months ago (2015-08-12 19:03:19 UTC) #2
Dirk Pranke
argh, not-lgtm.
5 years, 4 months ago (2015-08-12 19:03:30 UTC) #3
tfarina
ptal. https://codereview.chromium.org/1283133002/diff/1/BUILD.gn File BUILD.gn (right): https://codereview.chromium.org/1283133002/diff/1/BUILD.gn#newcode475 BUILD.gn:475: "//v8:postmortem-metadata", On 2015/08/12 19:03:18, Dirk Pranke wrote: > ...
5 years, 4 months ago (2015-08-12 19:17:45 UTC) #4
Dirk Pranke
lgtm
5 years, 4 months ago (2015-08-12 19:18:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1283133002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1283133002/20001
5 years, 4 months ago (2015-08-12 23:15:05 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-12 23:20:30 UTC) #8
commit-bot: I haz the power
5 years, 4 months ago (2015-08-12 23:41:22 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5132ba00872ecc7a9f1a71238bf390e09359ff5b
Cr-Commit-Position: refs/heads/master@{#343120}

Powered by Google App Engine
This is Rietveld 408576698