Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 1283033003: Remove inline header includes from non-inline headers (1). (Closed)

Created:
5 years, 4 months ago by Michael Starzinger
Modified:
5 years, 4 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove inline header includes from non-inline headers (1). This tries to remove includes of "-inl.h" headers from normal ".h" headers, thereby reducing the chance of any cyclic dependencies and decreasing the average size of our compilation units. Note that this change still leaves 7 violations of that rule in the code. However there now is the "tools/check-inline-includes.sh" tool detecting such violations. R=bmeurer@chromium.org Committed: https://crrev.com/00a07bc1b77420792de9ea8a1842f732b520198e Cr-Commit-Position: refs/heads/master@{#30125}

Patch Set 1 #

Patch Set 2 : Fix GCC compilation. #

Patch Set 3 : Fix GCC for realz. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -57 lines) Patch
M src/allocation-tracker.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/api.h View 1 chunk +1 line, -1 line 0 comments Download
M src/api.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/arm/regexp-macro-assembler-arm.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/arm64/macro-assembler-arm64.h View 1 chunk +2 lines, -3 lines 0 comments Download
M src/arm64/regexp-macro-assembler-arm64.h View 1 chunk +1 line, -3 lines 0 comments Download
M src/assembler.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/ast.h View 1 chunk +1 line, -1 line 0 comments Download
M src/char-predicates.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/common-node-cache.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/frame-states.h View 1 chunk +6 lines, -1 line 0 comments Download
M src/compiler/frame-states.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/cpu-profiler.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/cpu-profiler.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/d8.h View 1 chunk +1 line, -1 line 0 comments Download
M src/d8-posix.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/dateparser.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/dateparser.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
M src/dateparser-inl.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/gdb-jit.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/heap-profiler.h View 2 chunks +5 lines, -2 lines 0 comments Download
M src/heap-profiler.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/heap/heap.h View 2 chunks +0 lines, -2 lines 0 comments Download
M src/heap/heap-inl.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/ia32/regexp-macro-assembler-ia32.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/isolate.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/json-parser.h View 1 chunk +1 line, -1 line 0 comments Download
M src/jsregexp.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/mips/regexp-macro-assembler-mips.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/mips64/regexp-macro-assembler-mips64.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/ppc/regexp-macro-assembler-ppc.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/profile-generator.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/profile-generator.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M src/property.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime/runtime-json.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/scanner.h View 1 chunk +1 line, -1 line 0 comments Download
M src/string-builder.h View 1 chunk +5 lines, -1 line 0 comments Download
M src/string-builder.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/typing.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/unique.h View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/regexp-macro-assembler-x64.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/x87/regexp-macro-assembler-x87.h View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/cctest.h View 1 chunk +0 lines, -22 lines 0 comments Download
M test/cctest/test-heap-profiler.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/test-regexp.cc View 1 chunk +1 line, -0 lines 0 comments Download
A tools/check-inline-includes.sh View 1 chunk +19 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 7 (1 generated)
Michael Starzinger
5 years, 4 months ago (2015-08-11 18:05:30 UTC) #1
Benedikt Meurer
LGTM. I guess we can run the check script as part of presubmit once all ...
5 years, 4 months ago (2015-08-12 04:04:05 UTC) #2
Michael Starzinger
On 2015/08/12 04:04:05, Benedikt Meurer wrote: > LGTM. > > I guess we can run ...
5 years, 4 months ago (2015-08-12 07:09:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1283033003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1283033003/40001
5 years, 4 months ago (2015-08-12 07:30:08 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 4 months ago (2015-08-12 07:32:40 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-12 07:33:50 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/00a07bc1b77420792de9ea8a1842f732b520198e
Cr-Commit-Position: refs/heads/master@{#30125}

Powered by Google App Engine
This is Rietveld 408576698