Issue 1289553002: Make list constructor usable without list-inl.h header.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1289553002: Make list constructor usable without list-inl.h header. (Closed)

Created:
5 years, 4 months ago by Michael Starzinger

Modified:
5 years, 4 months ago

Reviewers:
Benedikt Meurer

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@local_cleanup-includes-inl-1

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

More Reviews

Description

Make list constructor usable without list-inl.h header. R=bmeurer@chromium.org Committed: https://crrev.com/8ad1778b500341e662144a952ec6aa4fa52ddf4c Cr-Commit-Position: refs/heads/master@{#30126}

Patch Set 1 #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -14 lines)			Patch
M	src/d8-posix.cc	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	src/list.h	View	1 chunk	+6 lines, -1 line	0 comments	Download
M	src/list-inl.h	View	1 chunk	+0 lines, -9 lines	0 comments	Download

Depends on Patchset:

Issue 1283033003 Patch 40001

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1289553002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1289553002/1

5 years, 4 months ago (2015-08-12 07:57:04 UTC) #4

commit-bot: I haz the power

5 years, 4 months ago (2015-08-12 08:00:24 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/8ad1778b500341e662144a952ec6aa4fa52ddf4c
Cr-Commit-Position: refs/heads/master@{#30126}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages