tools/check-inline-includes.sh - Issue 1283033003: Remove inline header includes from non-inline headers (1).

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/check-inline-includes.sh

Issue 1283033003: Remove inline header includes from non-inline headers (1). (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Fix GCC for realz. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 #!/bin/bash

	2 # Copyright 2015 the V8 project authors. All rights reserved.

	3 # Use of this source code is governed by a BSD-style license that can be

	4 # found in the LICENSE file.

	5

	6 v8_root=$(readlink -f $(dirname $BASH_SOURCE)/../)

	7 headers=$(find "$v8_root/src" -name '.h' -not -name '-inl.h')

	8

	9 for header in $headers; do

	10 inline_header_include=$(grep '#include ".*-inl.h"' "$header")

	11 if [ -n "$inline_header_include" ]; then

	12 echo "The following non-inline header seems to include an inline header:"

	13 echo " Header : $header"

	14 echo " Include: $inline_header_include"

	15 echo

	16 fi

	17 done

	18

	19 echo "Kthxbye."

OLD	NEW

« no previous file with comments | « test/cctest/test-regexp.cc ('k') | no next file » | no next file with comments »