Issue 1282673002: Make obtaining the Testable interface actually part of the interface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1282673002: Make obtaining the Testable interface actually part of the interface. (Closed)

Created:
5 years, 4 months ago by iannucci

Modified:
5 years, 4 months ago

Reviewers:
dnj, Vadim Sh., estaab, tandrii(chromium)

CC:
chromium-reviews

Base URL:
https://github.com/luci/gae.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Make obtaining the Testable interface actually part of the interface. Reduces the number of free casts, and will actually work with the upcoming Testable interface for datastore, which uses a checkfilter (and so casting won't work there anyway). R=vadimsh@chromium.org, dnj@chromium.org, estaab@chromium.org, tandrii@chromium.org BUG= Committed: https://github.com/luci/gae/commit/f21b29ee2a158d6d0debe551c308169110a3aca5

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+50 lines, -21 lines)			Patch
M	doc.go	View	1 chunk	+5 lines, -3 lines	0 comments	Download
M	filter/count/tq.go	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	filter/featureBreaker/tq.go	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	impl/dummy/dummy.go	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	impl/memory/taskqueue.go	View	2 chunks	+8 lines, -0 lines	0 comments	Download
M	impl/memory/taskqueue_data.go	View	2 chunks	+8 lines, -8 lines	0 comments	Download
M	impl/memory/taskqueue_test.go	View	7 chunks	+8 lines, -10 lines	0 comments	Download
M	impl/prod/taskqueue.go	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	service/taskqueue/interface.go	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	service/taskqueue/raw_interface.go	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	service/taskqueue/taskqueue.go	View	1 chunk	+4 lines, -0 lines	0 comments	Download

Dependent Patchsets:

Total messages: 4 (0 generated)

iannucci

On 2015/08/08 17:44:55, iannucci wrote: Monday morning bump

5 years, 4 months ago (2015-08-10 17:53:19 UTC) #2

iannucci

5 years, 4 months ago (2015-08-10 18:01:04 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
f21b29ee2a158d6d0debe551c308169110a3aca5 (presubmit successful).