Issue 1281173002: Refactor: Rename some files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1281173002: Refactor: Rename some files. (Closed)

Created:
5 years, 4 months ago by iannucci

Modified:
5 years, 4 months ago

Reviewers:
dnj, Vadim Sh., estaab, tandrii(chromium)

CC:
chromium-reviews

Base URL:
https://github.com/luci/gae.git@tweak_testable

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+-7 lines, -2446 lines)			Patch
A +	impl/memory/datastore.go	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	impl/memory/datastore_data.go	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	impl/memory/datastore_index.go	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	impl/memory/datastore_index_test.go	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	impl/memory/datastore_query.go	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	impl/memory/datastore_test.go	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
D	impl/memory/globalinfo.go	View	1 chunk	+0 lines, -66 lines	0 comments	Download
A +	impl/memory/info.go	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
D	impl/memory/plist.go	View	1 chunk	+0 lines, -289 lines	0 comments	Download
D	impl/memory/plist_test.go	View	1 chunk	+0 lines, -391 lines	0 comments	Download
D	impl/memory/raw_datastore.go	View	1 chunk	+0 lines, -128 lines	0 comments	Download
D	impl/memory/raw_datastore_data.go	View	1 chunk	+0 lines, -421 lines	0 comments	Download
D	impl/memory/raw_datastore_query.go	View	1 chunk	+0 lines, -578 lines	0 comments	Download
D	impl/memory/raw_datastore_test.go	View	1 chunk	+0 lines, -580 lines	0 comments	Download

Depends on Patchset:

Total messages: 4 (0 generated)

tandrii(chromium)

lgtm Did poor rietveld always show bogus diff numbers +1-1 for renames?

5 years, 4 months ago (2015-08-10 17:32:06 UTC) #2

iannucci

On 2015/08/10 17:32:06, tandrii(chromium) wrote: > lgtm > > Did poor rietveld always show bogus ...

5 years, 4 months ago (2015-08-10 17:38:07 UTC) #3

iannucci

5 years, 4 months ago (2015-08-10 18:01:31 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
60d79d7d3cf7621500aaafda506af9935f4ab174 (presubmit successful).