Make obtaining the Testable interface actually part of the interface.

impl/memory/taskqueue_test.go

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package memory
 
 import (
         "fmt"
         "math/rand"
         "net/http"
@@ skipping 13 matching lines @@
 func TestTaskQueue(t *testing.T) {
         t.Parallel()
 
         Convey("TaskQueue", t, func() {
                 now := time.Date(2000, time.January, 1, 1, 1, 1, 1, time.UTC)
                 c, tc := testclock.UseTime(context.Background(), now)
                 c = mathrand.Set(c, rand.New(rand.NewSource(clock.Now(c).UnixNano())))
                 c = Use(c)
 
                 tq := tqS.Get(c)
-                tqt := tq.Raw().(tqS.Testable)
+                tqt := tq.Testable()
+                So(tqt, ShouldNotBeNil)
 
                 So(tq, ShouldNotBeNil)
 
                 Convey("implements TQMultiReadWriter", func() {
                         Convey("Add", func() {
                                 t := tq.NewTask("/hello/world")
 
                                 Convey("works", func() {
                                         t.Delay = 4 * time.Second
                                         t.Header = http.Header{}
@@ skipping 193 matching lines @@
                         t := &tqS.Task{Path: "/hello/world"}
                         So(tq.Add(t, ""), ShouldBeNil)
 
                         t2 := &tqS.Task{Path: "/hi/city"}
                         So(tq.Add(t2, ""), ShouldBeNil)
 
                         So(tq.Delete(t2, ""), ShouldBeNil)
 
                         Convey("can view regular tasks", func() {
                                 dsS.Get(c).RunInTransaction(func(c context.Context) error {
-                                        tqt := tqS.Get(c).Raw().(tqS.Testable)
+                                        tqt := tqS.Get(c).Testable()
 
                                         So(tqt.GetScheduledTasks()["default"][t.Name], ShouldResemble, t)
                                         So(tqt.GetTombstonedTasks()["default"][t2.Name], ShouldResemble, t2)
                                         So(tqt.GetTransactionTasks()["default"], ShouldBeNil)
                                         return nil
                                 }, nil)
                         })
 
                         Convey("can add a new task", func() {
                                 t3 := &tqS.Task{Path: "/sandwitch/victory"}
 
                                 err := dsS.Get(c).RunInTransaction(func(c context.Context) error {
                                         tq := tqS.Get(c)
-                                        tqt := tq.Raw().(tqS.Testable)
+                                        tqt := tq.Testable()
 
                                         So(tq.Add(t3, ""), ShouldBeNil)
                                         So(t3.Name, ShouldEqual, "")
 
                                         So(tqt.GetScheduledTasks()["default"][t.Name], ShouldResemble, t)
                                         So(tqt.GetTombstonedTasks()["default"][t2.Name], ShouldResemble, t2)
                                         So(tqt.GetTransactionTasks()["default"][0], ShouldResemble, t3)
                                         return nil
                                 }, nil)
                                 So(err, ShouldBeNil)
@@ skipping 11 matching lines @@
                                 So(tqt.GetTransactionTasks()["default"], ShouldBeNil)
                         })
 
                         Convey("can add a new task (but reset the state in a test)", func() {
                                 t3 := &tqS.Task{Path: "/sandwitch/victory"}
 
                                 ttq := tqS.Interface(nil)
 
                                 dsS.Get(c).RunInTransaction(func(c context.Context) error {
                                         ttq = tqS.Get(c)
-                                        tqt := ttq.Raw().(tqS.Testable)
+                                        tqt := ttq.Testable()
 
                                         So(ttq.Add(t3, ""), ShouldBeNil)
 
                                         So(tqt.GetScheduledTasks()["default"][t.Name], ShouldResemble, t)
                                         So(tqt.GetTombstonedTasks()["default"][t2.Name], ShouldResemble, t2)
                                         So(tqt.GetTransactionTasks()["default"][0], ShouldResemble, t3)
 
                                         tqt.ResetTasks()
 
                                         So(len(tqt.GetScheduledTasks()["default"]), ShouldEqual, 0)
                                         So(len(tqt.GetTombstonedTasks()["default"]), ShouldEqual, 0)
                                         So(len(tqt.GetTransactionTasks()["default"]), ShouldEqual, 0)
 
                                         return nil
                                 }, nil)
 
                                 So(len(tqt.GetScheduledTasks()["default"]), ShouldEqual, 0)
                                 So(len(tqt.GetTombstonedTasks()["default"]), ShouldEqual, 0)
                                 So(len(tqt.GetTransactionTasks()["default"]), ShouldEqual, 0)
 
                                 Convey("and reusing a closed context is bad times", func() {
                                         So(ttq.Add(nil, "").Error(), ShouldContainSubstring, "expired")
                                 })
                         })
 
                         Convey("you can AddMulti as well", func() {
                                 dsS.Get(c).RunInTransaction(func(c context.Context) error {
                                         tq := tqS.Get(c)
-                                        tqt := tq.Raw().(tqS.Testable)
+                                        tqt := tq.Testable()
 
                                         t.Name = ""
                                         tasks := []*tqS.Task{t.Duplicate(), t.Duplicate(), t.Duplicate()}
                                         So(tq.AddMulti(tasks, ""), ShouldBeNil)
                                         So(len(tqt.GetScheduledTasks()["default"]), ShouldEqual, 1)
                                         So(len(tqt.GetTransactionTasks()["default"]), ShouldEqual, 3)
                                         return nil
                                 }, nil)
                                 So(len(tqt.GetScheduledTasks()["default"]), ShouldEqual, 4)
                                 So(len(tqt.GetTransactionTasks()["default"]), ShouldEqual, 0)
                         })
 
                         Convey("unless you add too many things", func() {
                                 dsS.Get(c).RunInTransaction(func(c context.Context) error {
                                         for i := 0; i < 5; i++ {
                                                 So(tqS.Get(c).Add(t.Duplicate(), ""), ShouldBeNil)
                                         }
                                         So(tqS.Get(c).Add(t, "").Error(), ShouldContainSubstring, "BAD_REQUEST")
                                         return nil
                                 }, nil)
                         })
 
                         Convey("unless you Add to a bad queue", func() {
                                 dsS.Get(c).RunInTransaction(func(c context.Context) error {
                                         So(tqS.Get(c).Add(t, "meat").Error(), ShouldContainSubstring, "UNKNOWN_QUEUE")
 
                                         Convey("unless you add it!", func() {
-                                                tqS.Get(c).Raw().(tqS.Testable).CreateQueue("meat")
+                                                tqS.Get(c).Testable().CreateQueue("meat")
                                                 So(tqS.Get(c).Add(t, "meat"), ShouldBeNil)
                                         })
 
                                         return nil
                                 }, nil)
                         })
 
                         Convey("No other features are available, however", func() {
                                 dsS.Get(c).RunInTransaction(func(c context.Context) error {
                                         So(tqS.Get(c).Delete(t, "").Error(), ShouldContainSubstring, "cannot DeleteMulti from a transaction")
@@ skipping 13 matching lines @@
 
                                 So(tqt.GetScheduledTasks()["default"][t.Name], ShouldResemble, t)
                                 So(tqt.GetTombstonedTasks()["default"][t2.Name], ShouldResemble, t2)
                                 So(tqt.GetTransactionTasks()["default"], ShouldBeNil)
                         })
 
                         Convey("likewise, a panic doesn't schedule anything", func() {
                                 func() {
                                         defer func() { recover() }()
                                         dsS.Get(c).RunInTransaction(func(c context.Context) error {
-                                                tq := tqS.Get(c).(interface {
-                                                        tqS.Testable
-                                                        tqS.Interface
-                                                })
+                                                tq := tqS.Get(c)
 
                                                 So(tq.Add(tq.NewTask("/sandwitch/victory"), ""), ShouldBeNil)
 
                                                 panic(fmt.Errorf("nooooo"))
                                         }, nil)
                                 }()
 
                                 So(tqt.GetScheduledTasks()["default"][t.Name], ShouldResemble, t)
                                 So(tqt.GetTombstonedTasks()["default"][t2.Name], ShouldResemble, t2)
                                 So(tqt.GetTransactionTasks()["default"], ShouldBeNil)
                         })
 
                 })
         })
 }