Remove listening of OMNIBOX_OPENED_URL from metrics code

Remove listening of OMNIBOX_OPENED_URL from metrics code

I am working to eliminate this notification entirely, as its usage is impeding
iOS upstreaming (see bug for details). This CL replaces its usage in
//chrome/browser/metrics with usage of OmniboxEventGlobalTracker.

BUG=517885
Committed: https://crrev.com/26b95242b8853564a5c7d406d2ba2c6d2d359096
Cr-Commit-Position: refs/heads/master@{#343662}

[blundell, 2015-08-07 14:51:36]

blundell@chromium.org changed reviewers:
+ asvitkine@chromium.org

[Alexei Svitkine (slow), 2015-08-07 14:57:37]

lgtm

https://codereview.chromium.org/1282473002/diff/1/chrome/browser/metrics/chro...
File chrome/browser/metrics/chrome_metrics_service_client.cc (right):

https://codereview.chromium.org/1282473002/diff/1/chrome/browser/metrics/chro...
chrome/browser/metrics/chrome_metrics_service_client.cc:626:
metrics_service_->OnApplicationNotIdle();
Nit: Since its body is a 1-liner, doesn't seem worth it to wrap in a function.
Just inline this into the two call sites.

https://codereview.chromium.org/1282473002/diff/1/chrome/browser/metrics/thre...
File chrome/browser/metrics/thread_watcher.cc (right):

https://codereview.chromium.org/1282473002/diff/1/chrome/browser/metrics/thre...
chrome/browser/metrics/thread_watcher.cc:715: }
Nit: Add an empty line after this.

[blundell, 2015-08-17 09:24:01]

https://codereview.chromium.org/1282473002/diff/1/chrome/browser/metrics/chro...
File chrome/browser/metrics/chrome_metrics_service_client.cc (right):

https://codereview.chromium.org/1282473002/diff/1/chrome/browser/metrics/chro...
chrome/browser/metrics/chrome_metrics_service_client.cc:626:
metrics_service_->OnApplicationNotIdle();
On 2015/08/07 14:57:37, Alexei Svitkine (OOO Aug15-24) wrote:
> Nit: Since its body is a 1-liner, doesn't seem worth it to wrap in a function.
> Just inline this into the two call sites.

Done.

https://codereview.chromium.org/1282473002/diff/1/chrome/browser/metrics/thre...
File chrome/browser/metrics/thread_watcher.cc (right):

https://codereview.chromium.org/1282473002/diff/1/chrome/browser/metrics/thre...
chrome/browser/metrics/thread_watcher.cc:715: }
On 2015/08/07 14:57:37, Alexei Svitkine (OOO Aug15-24) wrote:
> Nit: Add an empty line after this.

Done.

[blundell, 2015-08-17 09:24:04]

The CQ bit was checked by blundell@chromium.org

[blundell, 2015-08-17 09:24:05]

The patchset sent to the CQ was uploaded after l-g-t-m from
asvitkine@chromium.org
Link to the patchset: https://codereview.chromium.org/1282473002/#ps40001
(title: "Response to review")

[commit-bot: I haz the power, 2015-08-17 09:24:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1282473002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1282473002/40001

[commit-bot: I haz the power, 2015-08-17 10:29:31]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-08-17 10:30:01]

Patchset 3 (id:??) landed as
https://crrev.com/26b95242b8853564a5c7d406d2ba2c6d2d359096
Cr-Commit-Position: refs/heads/master@{#343662}